Run clang-tidy with modernize-use-override check

Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.

The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.

Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.

A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!

The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.

The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.

Test Plan: Compiles.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, apol, romangg, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D22371
master
Vlad Zagorodniy 5 years ago
parent eafe7aee65
commit 8af2fa73dc

@ -53,14 +53,6 @@ add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_USE_QSTRINGBUILDER -DQT_NO
set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON) set(CMAKE_CXX_STANDARD_REQUIRED ON)
# This is a workaround/compromise for a Kwin specific policy of not applying the relevant override fix.
# See thread in D18167.
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-inconsistent-missing-override")
else()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override")
endif()
find_package(Qt5Multimedia QUIET) find_package(Qt5Multimedia QUIET)
set_package_properties(Qt5Multimedia PROPERTIES set_package_properties(Qt5Multimedia PROPERTIES
PURPOSE "Runtime-only dependency for effect video playback" PURPOSE "Runtime-only dependency for effect video playback"

@ -332,7 +332,7 @@ class KWIN_EXPORT AbstractClient : public Toplevel
Q_PROPERTY(QString colorScheme READ colorScheme NOTIFY colorSchemeChanged) Q_PROPERTY(QString colorScheme READ colorScheme NOTIFY colorSchemeChanged)
public: public:
virtual ~AbstractClient(); ~AbstractClient() override;
QWeakPointer<TabBox::TabBoxClientImpl> tabBoxClient() const { QWeakPointer<TabBox::TabBoxClientImpl> tabBoxClient() const {
return m_tabBoxClient.toWeakRef(); return m_tabBoxClient.toWeakRef();
@ -479,7 +479,7 @@ public:
int desktop() const override { int desktop() const override {
return m_desktops.isEmpty() ? (int)NET::OnAllDesktops : m_desktops.last()->x11DesktopNumber(); return m_desktops.isEmpty() ? (int)NET::OnAllDesktops : m_desktops.last()->x11DesktopNumber();
} }
virtual QVector<VirtualDesktop *> desktops() const { QVector<VirtualDesktop *> desktops() const override {
return m_desktops; return m_desktops;
} }
QVector<uint> x11DesktopIds() const; QVector<uint> x11DesktopIds() const;

@ -57,7 +57,7 @@ class KWIN_EXPORT AbstractWaylandOutput : public AbstractOutput
Q_OBJECT Q_OBJECT
public: public:
explicit AbstractWaylandOutput(QObject *parent = nullptr); explicit AbstractWaylandOutput(QObject *parent = nullptr);
virtual ~AbstractWaylandOutput(); ~AbstractWaylandOutput() override;
QString name() const override; QString name() const override;
bool isEnabled() const { bool isEnabled() const {

@ -40,7 +40,7 @@ class KWIN_EXPORT Activities : public QObject
Q_OBJECT Q_OBJECT
public: public:
~Activities(); ~Activities() override;
bool stop(const QString &id); bool stop(const QString &id);
bool start(const QString &id); bool start(const QString &id);

@ -27,7 +27,7 @@ class FakeEffect : public Effect
Q_OBJECT Q_OBJECT
public: public:
FakeEffect() {} FakeEffect() {}
virtual ~FakeEffect() {} ~FakeEffect() override {}
static bool supported() { static bool supported() {
return effects->isOpenGLCompositing(); return effects->isOpenGLCompositing();

@ -27,7 +27,7 @@ class FakeVersionEffect : public Effect
Q_OBJECT Q_OBJECT
public: public:
FakeVersionEffect() {} FakeVersionEffect() {}
virtual ~FakeVersionEffect() {} ~FakeVersionEffect() override {}
}; };
} // namespace } // namespace
@ -39,7 +39,7 @@ class FakeEffectPluginFactory : public KWin::EffectPluginFactory
Q_INTERFACES(KPluginFactory) Q_INTERFACES(KPluginFactory)
public: public:
FakeEffectPluginFactory() {} FakeEffectPluginFactory() {}
~FakeEffectPluginFactory() {} ~FakeEffectPluginFactory() override {}
KWin::Effect *createEffect() const override { KWin::Effect *createEffect() const override {
return new KWin::FakeVersionEffect(); return new KWin::FakeVersionEffect();
} }

@ -413,7 +413,7 @@ class HelperWindow : public QRasterWindow
Q_OBJECT Q_OBJECT
public: public:
HelperWindow() : QRasterWindow(nullptr) {} HelperWindow() : QRasterWindow(nullptr) {}
~HelperWindow() = default; ~HelperWindow() override = default;
Q_SIGNALS: Q_SIGNALS:
void entered(); void entered();

@ -28,7 +28,7 @@ class Window : public QRasterWindow
Q_OBJECT Q_OBJECT
public: public:
explicit Window(); explicit Window();
virtual ~Window(); ~Window() override;
protected: protected:
void paintEvent(QPaintEvent *event) override; void paintEvent(QPaintEvent *event) override;

@ -28,7 +28,7 @@ class Window : public QRasterWindow
Q_OBJECT Q_OBJECT
public: public:
explicit Window(); explicit Window();
virtual ~Window(); ~Window() override;
protected: protected:
void paintEvent(QPaintEvent *event) override; void paintEvent(QPaintEvent *event) override;

@ -84,7 +84,7 @@ class HelperWindow : public QRasterWindow
Q_OBJECT Q_OBJECT
public: public:
HelperWindow(); HelperWindow();
~HelperWindow(); ~HelperWindow() override;
QPoint latestGlobalMousePos() const { QPoint latestGlobalMousePos() const {
return m_latestGlobalMousePos; return m_latestGlobalMousePos;

@ -67,7 +67,7 @@ class WaylandTestApplication : public ApplicationWaylandAbstract
Q_OBJECT Q_OBJECT
public: public:
WaylandTestApplication(OperationMode mode, int &argc, char **argv); WaylandTestApplication(OperationMode mode, int &argc, char **argv);
virtual ~WaylandTestApplication(); ~WaylandTestApplication() override;
protected: protected:
void performStartup() override; void performStartup() override;

@ -93,7 +93,7 @@ class HelperEffect : public Effect
Q_OBJECT Q_OBJECT
public: public:
HelperEffect() {} HelperEffect() {}
~HelperEffect() {} ~HelperEffect() override {}
void windowInputMouseEvent(QEvent*) override { void windowInputMouseEvent(QEvent*) override {
emit inputEvent(); emit inputEvent();

@ -61,7 +61,7 @@ class Target : public QObject
public: public:
Target(); Target();
virtual ~Target(); ~Target() override;
public Q_SLOTS: public Q_SLOTS:
Q_SCRIPTABLE void shortcut(); Q_SCRIPTABLE void shortcut();

@ -70,7 +70,7 @@ class Target : public QObject
public: public:
Target(); Target();
virtual ~Target(); ~Target() override;
public Q_SLOTS: public Q_SLOTS:
Q_SCRIPTABLE void shortcut(); Q_SCRIPTABLE void shortcut();

@ -207,7 +207,7 @@ class HelperWindow : public QRasterWindow
Q_OBJECT Q_OBJECT
public: public:
HelperWindow(); HelperWindow();
~HelperWindow(); ~HelperWindow() override;
protected: protected:
void paintEvent(QPaintEvent *event) override; void paintEvent(QPaintEvent *event) override;

@ -1079,7 +1079,7 @@ class HelperEffect : public Effect
Q_OBJECT Q_OBJECT
public: public:
HelperEffect() {} HelperEffect() {}
~HelperEffect() {} ~HelperEffect() override {}
}; };
void PointerInputTest::testEffectOverrideCursorImage() void PointerInputTest::testEffectOverrideCursorImage()

@ -31,7 +31,7 @@ class AbstractClient : public QObject
Q_OBJECT Q_OBJECT
public: public:
explicit AbstractClient(QObject *parent); explicit AbstractClient(QObject *parent);
virtual ~AbstractClient(); ~AbstractClient() override;
int screen() const; int screen() const;
bool isOnScreen(int screen) const; bool isOnScreen(int screen) const;

@ -33,7 +33,7 @@ class Client : public AbstractClient
Q_OBJECT Q_OBJECT
public: public:
explicit Client(QObject *parent); explicit Client(QObject *parent);
virtual ~Client(); ~Client() override;
void showOnScreenEdge() override; void showOnScreenEdge() override;
}; };

@ -29,7 +29,7 @@ class MockEffectsHandler : public KWin::EffectsHandler
public: public:
explicit MockEffectsHandler(KWin::CompositingType type); explicit MockEffectsHandler(KWin::CompositingType type);
void activateWindow(KWin::EffectWindow *) override {} void activateWindow(KWin::EffectWindow *) override {}
KWin::Effect *activeFullScreenEffect() const { KWin::Effect *activeFullScreenEffect() const override {
return nullptr; return nullptr;
} }
bool hasActiveFullScreenEffect() const override { bool hasActiveFullScreenEffect() const override {
@ -271,7 +271,7 @@ public:
} }
void hideOnScreenMessage(OnScreenMessageHideFlags flags = OnScreenMessageHideFlags()) override { Q_UNUSED(flags)} void hideOnScreenMessage(OnScreenMessageHideFlags flags = OnScreenMessageHideFlags()) override { Q_UNUSED(flags)}
void windowToDesktops(KWin::EffectWindow *w, const QVector<uint> &desktops) { void windowToDesktops(KWin::EffectWindow *w, const QVector<uint> &desktops) override {
Q_UNUSED(w) Q_UNUSED(w)
Q_UNUSED(desktops) Q_UNUSED(desktops)
} }

@ -30,7 +30,7 @@ class MockScreens : public Screens
Q_OBJECT Q_OBJECT
public: public:
explicit MockScreens(QObject *parent = nullptr); explicit MockScreens(QObject *parent = nullptr);
virtual ~MockScreens(); ~MockScreens() override;
QRect geometry(int screen) const override; QRect geometry(int screen) const override;
int number(const QPoint &pos) const override; int number(const QPoint &pos) const override;
QString name(int screen) const override; QString name(int screen) const override;

@ -38,7 +38,7 @@ class MockWorkspace : public QObject
Q_OBJECT Q_OBJECT
public: public:
explicit MockWorkspace(QObject *parent = nullptr); explicit MockWorkspace(QObject *parent = nullptr);
virtual ~MockWorkspace(); ~MockWorkspace() override;
AbstractClient *activeClient() const; AbstractClient *activeClient() const;
AbstractClient *moveResizeClient() const; AbstractClient *moveResizeClient() const;
void setShowingDesktop(bool showing); void setShowingDesktop(bool showing);

@ -31,38 +31,38 @@ class MockTabBoxClient : public TabBox::TabBoxClient
{ {
public: public:
explicit MockTabBoxClient(QString caption, WId id); explicit MockTabBoxClient(QString caption, WId id);
virtual bool isMinimized() const { bool isMinimized() const override {
return false; return false;
} }
virtual QString caption() const { QString caption() const override {
return m_caption; return m_caption;
} }
virtual void close(); void close() override;
virtual int height() const { int height() const override {
return 100; return 100;
} }
virtual QPixmap icon(const QSize &size = QSize(32, 32)) const { virtual QPixmap icon(const QSize &size = QSize(32, 32)) const {
return QPixmap(size); return QPixmap(size);
} }
virtual bool isCloseable() const { bool isCloseable() const override {
return true; return true;
} }
virtual bool isFirstInTabBox() const { bool isFirstInTabBox() const override {
return false; return false;
} }
virtual int width() const { int width() const override {
return 100; return 100;
} }
virtual WId window() const { WId window() const override {
return m_wId; return m_wId;
} }
virtual int x() const { int x() const override {
return 0; return 0;
} }
virtual int y() const { int y() const override {
return 0; return 0;
} }
virtual QIcon icon() const { QIcon icon() const override {
return QIcon(); return QIcon();
} }

@ -28,70 +28,70 @@ class MockTabBoxHandler : public TabBox::TabBoxHandler
Q_OBJECT Q_OBJECT
public: public:
MockTabBoxHandler(QObject *parent = nullptr); MockTabBoxHandler(QObject *parent = nullptr);
virtual ~MockTabBoxHandler(); ~MockTabBoxHandler() override;
virtual void activateAndClose() { void activateAndClose() override {
} }
virtual QWeakPointer< TabBox::TabBoxClient > activeClient() const; QWeakPointer< TabBox::TabBoxClient > activeClient() const override;
void setActiveClient(const QWeakPointer<TabBox::TabBoxClient> &client); void setActiveClient(const QWeakPointer<TabBox::TabBoxClient> &client);
virtual int activeScreen() const { int activeScreen() const override {
return 0; return 0;
} }
virtual QWeakPointer< TabBox::TabBoxClient > clientToAddToList(TabBox::TabBoxClient *client, int desktop) const; QWeakPointer< TabBox::TabBoxClient > clientToAddToList(TabBox::TabBoxClient *client, int desktop) const override;
virtual int currentDesktop() const { int currentDesktop() const override {
return 1; return 1;
} }
virtual QWeakPointer< TabBox::TabBoxClient > desktopClient() const { QWeakPointer< TabBox::TabBoxClient > desktopClient() const override {
return QWeakPointer<TabBox::TabBoxClient>(); return QWeakPointer<TabBox::TabBoxClient>();
} }
virtual QString desktopName(int desktop) const { QString desktopName(int desktop) const override {
Q_UNUSED(desktop) Q_UNUSED(desktop)
return "desktop 1"; return "desktop 1";
} }
virtual QString desktopName(TabBox::TabBoxClient *client) const { QString desktopName(TabBox::TabBoxClient *client) const override {
Q_UNUSED(client) Q_UNUSED(client)
return "desktop"; return "desktop";
} }
virtual void elevateClient(TabBox::TabBoxClient *c, QWindow *tabbox, bool elevate) const { void elevateClient(TabBox::TabBoxClient *c, QWindow *tabbox, bool elevate) const override {
Q_UNUSED(c) Q_UNUSED(c)
Q_UNUSED(tabbox) Q_UNUSED(tabbox)
Q_UNUSED(elevate) Q_UNUSED(elevate)
} }
virtual void shadeClient(TabBox::TabBoxClient *c, bool b) const { void shadeClient(TabBox::TabBoxClient *c, bool b) const override {
Q_UNUSED(c) Q_UNUSED(c)
Q_UNUSED(b) Q_UNUSED(b)
} }
virtual void hideOutline() { virtual void hideOutline() {
} }
virtual QWeakPointer< TabBox::TabBoxClient > nextClientFocusChain(TabBox::TabBoxClient *client) const; QWeakPointer< TabBox::TabBoxClient > nextClientFocusChain(TabBox::TabBoxClient *client) const override;
virtual QWeakPointer<TabBox::TabBoxClient> firstClientFocusChain() const; QWeakPointer<TabBox::TabBoxClient> firstClientFocusChain() const override;
virtual bool isInFocusChain (TabBox::TabBoxClient* client) const; bool isInFocusChain (TabBox::TabBoxClient* client) const override;
virtual int nextDesktopFocusChain(int desktop) const { int nextDesktopFocusChain(int desktop) const override {
Q_UNUSED(desktop) Q_UNUSED(desktop)
return 1; return 1;
} }
virtual int numberOfDesktops() const { int numberOfDesktops() const override {
return 1; return 1;
} }
virtual QVector< xcb_window_t > outlineWindowIds() const { virtual QVector< xcb_window_t > outlineWindowIds() const {
return QVector<xcb_window_t>(); return QVector<xcb_window_t>();
} }
virtual bool isKWinCompositing() const { bool isKWinCompositing() const override {
return false; return false;
} }
virtual void raiseClient(TabBox::TabBoxClient *c) const { void raiseClient(TabBox::TabBoxClient *c) const override {
Q_UNUSED(c) Q_UNUSED(c)
} }
virtual void restack(TabBox::TabBoxClient *c, TabBox::TabBoxClient *under) { void restack(TabBox::TabBoxClient *c, TabBox::TabBoxClient *under) override {
Q_UNUSED(c) Q_UNUSED(c)
Q_UNUSED(under) Q_UNUSED(under)
} }
virtual void showOutline(const QRect &outline) { virtual void showOutline(const QRect &outline) {
Q_UNUSED(outline) Q_UNUSED(outline)
} }
virtual TabBox::TabBoxClientList stackingOrder() const { TabBox::TabBoxClientList stackingOrder() const override {
return TabBox::TabBoxClientList(); return TabBox::TabBoxClientList();
} }
virtual void grabbedKeyEvent(QKeyEvent *event) const; void grabbedKeyEvent(QKeyEvent *event) const override;
void highlightWindows(TabBox::TabBoxClient *window = nullptr, QWindow *controller = nullptr) override { void highlightWindows(TabBox::TabBoxClient *window = nullptr, QWindow *controller = nullptr) override {
Q_UNUSED(window) Q_UNUSED(window)

@ -52,7 +52,7 @@ public:
this, this,
SLOT(slotEnabledChanged())); SLOT(slotEnabledChanged()));
} }
~DbusPropertyHelper() = default; ~DbusPropertyHelper() override = default;
Q_SIGNALS: Q_SIGNALS:
void enabledChanged(); void enabledChanged();

@ -35,7 +35,7 @@ class X11TestApplication : public Application
Q_OBJECT Q_OBJECT
public: public:
X11TestApplication(int &argc, char **argv); X11TestApplication(int &argc, char **argv);
virtual ~X11TestApplication(); ~X11TestApplication() override;
protected: protected:
void performStartup() override; void performStartup() override;

@ -90,7 +90,7 @@ public:
explicit Client(); explicit Client();
xcb_window_t wrapperId() const; xcb_window_t wrapperId() const;
xcb_window_t inputId() const { return m_decoInputExtent; } xcb_window_t inputId() const { return m_decoInputExtent; }
virtual xcb_window_t frameId() const override; xcb_window_t frameId() const override;
bool isTransient() const override; bool isTransient() const override;
bool groupTransient() const override; bool groupTransient() const override;
@ -111,17 +111,17 @@ public:
QSize minSize() const override; QSize minSize() const override;
QSize maxSize() const override; QSize maxSize() const override;
QSize basicUnit() const; QSize basicUnit() const;
virtual QSize clientSize() const; QSize clientSize() const override;
QPoint inputPos() const { return input_offset; } // Inside of geometry() QPoint inputPos() const { return input_offset; } // Inside of geometry()
bool windowEvent(xcb_generic_event_t *e); bool windowEvent(xcb_generic_event_t *e);
NET::WindowType windowType(bool direct = false, int supported_types = 0) const; NET::WindowType windowType(bool direct = false, int supported_types = 0) const override;
bool manage(xcb_window_t w, bool isMapped); bool manage(xcb_window_t w, bool isMapped);
void releaseWindow(bool on_shutdown = false); void releaseWindow(bool on_shutdown = false);
void destroyClient(); void destroyClient();
virtual QStringList activities() const; QStringList activities() const override;
void setOnActivity(const QString &activity, bool enable); void setOnActivity(const QString &activity, bool enable);
void setOnAllActivities(bool set) override; void setOnAllActivities(bool set) override;
void setOnActivities(QStringList newActivitiesList) override; void setOnActivities(QStringList newActivitiesList) override;
@ -203,7 +203,7 @@ public:
void hideClient(bool hide) override; void hideClient(bool hide) override;
bool hiddenPreview() const; ///< Window is mapped in order to get a window pixmap bool hiddenPreview() const; ///< Window is mapped in order to get a window pixmap
virtual bool setupCompositing(); bool setupCompositing() override;
void finishCompositing(ReleaseReason releaseReason = ReleaseReason::Release) override; void finishCompositing(ReleaseReason releaseReason = ReleaseReason::Release) override;
void setBlockingCompositing(bool block); void setBlockingCompositing(bool block);
inline bool isBlockingCompositing() { return blocks_compositing; } inline bool isBlockingCompositing() { return blocks_compositing; }
@ -263,9 +263,9 @@ public:
bool hasOffscreenXineramaStrut() const; bool hasOffscreenXineramaStrut() const;
// Decorations <-> Effects // Decorations <-> Effects
QRect decorationRect() const; QRect decorationRect() const override;
QRect transparentRect() const; QRect transparentRect() const override;
bool isClientSideDecorated() const; bool isClientSideDecorated() const;
bool wantsShadowToBeRendered() const override; bool wantsShadowToBeRendered() const override;
@ -281,7 +281,7 @@ public:
//sets whether the client should be faked as being on all activities (and be shown during session save) //sets whether the client should be faked as being on all activities (and be shown during session save)
void setSessionActivityOverride(bool needed); void setSessionActivityOverride(bool needed);
virtual bool isClient() const; bool isClient() const override;
template <typename T> template <typename T>
void print(T &stream) const; void print(T &stream) const;
@ -327,20 +327,20 @@ private Q_SLOTS:
private: private:
// Use Workspace::createClient() // Use Workspace::createClient()
virtual ~Client(); ///< Use destroyClient() or releaseWindow() ~Client() override; ///< Use destroyClient() or releaseWindow()
// Handlers for X11 events // Handlers for X11 events
bool mapRequestEvent(xcb_map_request_event_t *e); bool mapRequestEvent(xcb_map_request_event_t *e);
void unmapNotifyEvent(xcb_unmap_notify_event_t *e); void unmapNotifyEvent(xcb_unmap_notify_event_t *e);
void destroyNotifyEvent(xcb_destroy_notify_event_t *e); void destroyNotifyEvent(xcb_destroy_notify_event_t *e);
void configureRequestEvent(xcb_configure_request_event_t *e); void configureRequestEvent(xcb_configure_request_event_t *e);
virtual void propertyNotifyEvent(xcb_property_notify_event_t *e) override; void propertyNotifyEvent(xcb_property_notify_event_t *e) override;
void clientMessageEvent(xcb_client_message_event_t *e) override; void clientMessageEvent(xcb_client_message_event_t *e) override;
void enterNotifyEvent(xcb_enter_notify_event_t *e); void enterNotifyEvent(xcb_enter_notify_event_t *e);
void leaveNotifyEvent(xcb_leave_notify_event_t *e); void leaveNotifyEvent(xcb_leave_notify_event_t *e);
void focusInEvent(xcb_focus_in_event_t *e); void focusInEvent(xcb_focus_in_event_t *e);
void focusOutEvent(xcb_focus_out_event_t *e); void focusOutEvent(xcb_focus_out_event_t *e);
virtual void damageNotifyEvent(); void damageNotifyEvent() override;
bool buttonPressEvent(xcb_window_t w, int button, int state, int x, int y, int x_root, int y_root, xcb_timestamp_t time = XCB_CURRENT_TIME); bool buttonPressEvent(xcb_window_t w, int button, int state, int x, int y, int x_root, int y_root, xcb_timestamp_t time = XCB_CURRENT_TIME);
bool buttonReleaseEvent(xcb_window_t w, int button, int state, int x, int y, int x_root, int y_root); bool buttonReleaseEvent(xcb_window_t w, int button, int state, int x, int y, int x_root, int y_root);
@ -349,7 +349,7 @@ private:
Client* findAutogroupCandidate() const; Client* findAutogroupCandidate() const;
protected: protected:
virtual void debug(QDebug& stream) const; void debug(QDebug& stream) const override;
void addDamage(const QRegion &damage) override; void addDamage(const QRegion &damage) override;
bool belongsToSameApplication(const AbstractClient *other, SameApplicationChecks checks) const override; bool belongsToSameApplication(const AbstractClient *other, SameApplicationChecks checks) const override;
void doSetActive() override; void doSetActive() override;

@ -35,7 +35,7 @@ class GetAddrInfo : public QObject
Q_OBJECT Q_OBJECT
public: public:
explicit GetAddrInfo(const QByteArray &hostName, QObject *parent = NULL); explicit GetAddrInfo(const QByteArray &hostName, QObject *parent = NULL);
virtual ~GetAddrInfo(); ~GetAddrInfo() override;
void resolve(); void resolve();
@ -65,7 +65,7 @@ class ClientMachine : public QObject
Q_OBJECT Q_OBJECT
public: public:
explicit ClientMachine(QObject *parent = NULL); explicit ClientMachine(QObject *parent = NULL);
virtual ~ClientMachine(); ~ClientMachine() override;
void resolve(xcb_window_t window, xcb_window_t clientLeader); void resolve(xcb_window_t window, xcb_window_t clientLeader);
const QByteArray &hostName() const; const QByteArray &hostName() const;

@ -39,7 +39,7 @@ class ColorCorrectDBusInterface : public QObject
public: public:
explicit ColorCorrectDBusInterface(Manager *parent); explicit ColorCorrectDBusInterface(Manager *parent);
virtual ~ColorCorrectDBusInterface() = default; ~ColorCorrectDBusInterface() override = default;
public Q_SLOTS: public Q_SLOTS:
/** /**

@ -97,7 +97,7 @@ class KWIN_EXPORT Cursor : public QObject
{ {
Q_OBJECT Q_OBJECT
public: public:
virtual ~Cursor(); ~Cursor() override;
void startMousePolling(); void startMousePolling();
void stopMousePolling(); void stopMousePolling();
/** /**
@ -258,11 +258,11 @@ class InputRedirectionCursor : public Cursor
Q_OBJECT Q_OBJECT
public: public:
explicit InputRedirectionCursor(QObject *parent); explicit InputRedirectionCursor(QObject *parent);
virtual ~InputRedirectionCursor(); ~InputRedirectionCursor() override;
protected: protected:
virtual void doSetPos(); void doSetPos() override;
virtual void doStartCursorTracking(); void doStartCursorTracking() override;
virtual void doStopCursorTracking(); void doStopCursorTracking() override;
private Q_SLOTS: private Q_SLOTS:
void slotPosChanged(const QPointF &pos); void slotPosChanged(const QPointF &pos);
void slotPointerButtonChanged(); void slotPointerButtonChanged();

@ -52,7 +52,7 @@ class DBusInterface: public QObject, protected QDBusContext
Q_CLASSINFO("D-Bus Interface", "org.kde.KWin") Q_CLASSINFO("D-Bus Interface", "org.kde.KWin")
public: public:
explicit DBusInterface(QObject *parent); explicit DBusInterface(QObject *parent);
virtual ~DBusInterface(); ~DBusInterface() override;
public: // PROPERTIES public: // PROPERTIES
public Q_SLOTS: // METHODS public Q_SLOTS: // METHODS
@ -125,7 +125,7 @@ class CompositorDBusInterface : public QObject
Q_PROPERTY(bool platformRequiresCompositing READ platformRequiresCompositing) Q_PROPERTY(bool platformRequiresCompositing READ platformRequiresCompositing)
public: public:
explicit CompositorDBusInterface(Compositor *parent); explicit CompositorDBusInterface(Compositor *parent);
virtual ~CompositorDBusInterface() = default; ~CompositorDBusInterface() override = default;
bool isActive() const; bool isActive() const;
bool isCompositingPossible() const; bool isCompositingPossible() const;
@ -211,7 +211,7 @@ class VirtualDesktopManagerDBusInterface : public QObject
public: public:
VirtualDesktopManagerDBusInterface(VirtualDesktopManager *parent); VirtualDesktopManagerDBusInterface(VirtualDesktopManager *parent);
~VirtualDesktopManagerDBusInterface() = default; ~VirtualDesktopManagerDBusInterface() override = default;
uint count() const; uint count() const;

@ -49,7 +49,7 @@ class KWIN_EXPORT DebugConsoleModel : public QAbstractItemModel
Q_OBJECT Q_OBJECT
public: public:
explicit DebugConsoleModel(QObject *parent = nullptr); explicit DebugConsoleModel(QObject *parent = nullptr);
virtual ~DebugConsoleModel(); ~DebugConsoleModel() override;
int columnCount(const QModelIndex &parent) const override; int columnCount(const QModelIndex &parent) const override;
@ -90,7 +90,7 @@ class DebugConsoleDelegate : public QStyledItemDelegate
Q_OBJECT Q_OBJECT
public: public:
explicit DebugConsoleDelegate(QObject *parent = nullptr); explicit DebugConsoleDelegate(QObject *parent = nullptr);
virtual ~DebugConsoleDelegate(); ~DebugConsoleDelegate() override;
QString displayText(const QVariant &value, const QLocale &locale) const override; QString displayText(const QVariant &value, const QLocale &locale) const override;
}; };
@ -100,7 +100,7 @@ class KWIN_EXPORT DebugConsole : public QWidget
Q_OBJECT Q_OBJECT
public: public:
DebugConsole(); DebugConsole();
virtual ~DebugConsole(); ~DebugConsole() override;
protected: protected:
void showEvent(QShowEvent *event) override; void showEvent(QShowEvent *event) override;
@ -118,7 +118,7 @@ class SurfaceTreeModel : public QAbstractItemModel
Q_OBJECT Q_OBJECT
public: public:
explicit SurfaceTreeModel(QObject *parent = nullptr); explicit SurfaceTreeModel(QObject *parent = nullptr);
virtual ~SurfaceTreeModel(); ~SurfaceTreeModel() override;
int columnCount(const QModelIndex &parent) const override; int columnCount(const QModelIndex &parent) const override;
QVariant data(const QModelIndex &index, int role) const override; QVariant data(const QModelIndex &index, int role) const override;
@ -131,7 +131,7 @@ class DebugConsoleFilter : public InputEventSpy
{ {
public: public:
explicit DebugConsoleFilter(QTextEdit *textEdit); explicit DebugConsoleFilter(QTextEdit *textEdit);
virtual ~DebugConsoleFilter(); ~DebugConsoleFilter() override;
void pointerEvent(MouseEvent *event) override; void pointerEvent(MouseEvent *event) override;
void wheelEvent(WheelEvent *event) override; void wheelEvent(WheelEvent *event) override;
@ -166,7 +166,7 @@ class InputDeviceModel : public QAbstractItemModel
Q_OBJECT Q_OBJECT
public: public:
explicit InputDeviceModel(QObject *parent = nullptr); explicit InputDeviceModel(QObject *parent = nullptr);
virtual ~InputDeviceModel(); ~InputDeviceModel() override;
int columnCount(const QModelIndex &parent) const override; int columnCount(const QModelIndex &parent) const override;
QVariant data(const QModelIndex &index, int role) const override; QVariant data(const QModelIndex &index, int role) const override;

@ -42,7 +42,7 @@ class DecoratedClientImpl : public QObject, public KDecoration2::ApplicationMenu
Q_OBJECT Q_OBJECT
public: public:
explicit DecoratedClientImpl(AbstractClient *client, KDecoration2::DecoratedClient *decoratedClient, KDecoration2::Decoration *decoration); explicit DecoratedClientImpl(AbstractClient *client, KDecoration2::DecoratedClient *decoratedClient, KDecoration2::Decoration *decoration);
virtual ~DecoratedClientImpl(); ~DecoratedClientImpl() override;
QString caption() const override; QString caption() const override;
WId decorationId() const override; WId decorationId() const override;
int desktop() const override; int desktop() const override;
@ -87,7 +87,7 @@ public:
void requestToggleOnAllDesktops() override; void requestToggleOnAllDesktops() override;
void requestToggleShade() override; void requestToggleShade() override;
void showApplicationMenu(int actionId); void showApplicationMenu(int actionId) override;
AbstractClient *client() { AbstractClient *client() {
return m_client; return m_client;

@ -48,7 +48,7 @@ class KWIN_EXPORT DecorationBridge : public KDecoration2::DecorationBridge
{ {
Q_OBJECT Q_OBJECT
public: public:
virtual ~DecorationBridge(); ~DecorationBridge() override;
void init(); void init();
KDecoration2::Decoration *createDecoration(AbstractClient *client); KDecoration2::Decoration *createDecoration(AbstractClient *client);

@ -39,7 +39,7 @@ class KWIN_EXPORT Renderer : public QObject
{ {
Q_OBJECT Q_OBJECT
public: public:
virtual ~Renderer(); ~Renderer() override;
void schedule(const QRect &rect); void schedule(const QRect &rect);

@ -36,7 +36,7 @@ class SettingsImpl : public QObject, public KDecoration2::DecorationSettingsPriv
Q_OBJECT Q_OBJECT
public: public:
explicit SettingsImpl(KDecoration2::DecorationSettings *parent); explicit SettingsImpl(KDecoration2::DecorationSettings *parent);
virtual ~SettingsImpl(); ~SettingsImpl() override;
bool isAlphaChannelSupported() const override; bool isAlphaChannelSupported() const override;
bool isOnAllDesktopsAvailable() const override; bool isOnAllDesktopsAvailable() const override;
bool isCloseOnDoubleClickOnMenu() const override; bool isCloseOnDoubleClickOnMenu() const override;

@ -44,23 +44,23 @@ public:
void refWindow(); void refWindow();
void unrefWindow(); void unrefWindow();
void discard(); void discard();
virtual int desktop() const; int desktop() const override;
virtual QStringList activities() const; QStringList activities() const override;
virtual QVector<VirtualDesktop *> desktops() const; QVector<VirtualDesktop *> desktops() const override;
virtual QPoint clientPos() const; QPoint clientPos() const override;
virtual QSize clientSize() const; QSize clientSize() const override;
QPoint clientContentPos() const override { QPoint clientContentPos() const override {
return m_contentPos; return m_contentPos;
} }
virtual QRect transparentRect() const; QRect transparentRect() const override;
virtual bool isDeleted() const; bool isDeleted() const override;
virtual xcb_window_t frameId() const override; xcb_window_t frameId() const override;
bool noBorder() const { bool noBorder() const {
return no_border; return no_border;
} }
void layoutDecorationRects(QRect &left, QRect &top, QRect &right, QRect &bottom) const; void layoutDecorationRects(QRect &left, QRect &top, QRect &right, QRect &bottom) const;
QRect decorationRect() const; QRect decorationRect() const override;
virtual Layer layer() const { Layer layer() const override {
return m_layer; return m_layer;
} }
bool isMinimized() const { bool isMinimized() const {
@ -72,7 +72,7 @@ public:
QList<AbstractClient*> mainClients() const { QList<AbstractClient*> mainClients() const {
return m_mainClients; return m_mainClients;
} }
NET::WindowType windowType(bool direct = false, int supported_types = 0) const; NET::WindowType windowType(bool direct = false, int supported_types = 0) const override;
bool wasClient() const { bool wasClient() const {
return m_wasClient; return m_wasClient;
} }
@ -185,7 +185,7 @@ public:
} }
protected: protected:
virtual void debug(QDebug& stream) const; void debug(QDebug& stream) const override;
private Q_SLOTS: private Q_SLOTS:
void mainClientClosed(KWin::Toplevel *client); void mainClientClosed(KWin::Toplevel *client);
@ -194,7 +194,7 @@ private Q_SLOTS:
private: private:
Deleted(); // use create() Deleted(); // use create()
void copyToDeleted(Toplevel* c); void copyToDeleted(Toplevel* c);
virtual ~Deleted(); // deleted only using unrefWindow() ~Deleted() override; // deleted only using unrefWindow()
void addTransient(Deleted *transient); void addTransient(Deleted *transient);
void removeTransient(Deleted *transient); void removeTransient(Deleted *transient);

@ -70,7 +70,7 @@ class KWIN_EXPORT AbstractEffectLoader : public QObject
{ {
Q_OBJECT Q_OBJECT
public: public:
virtual ~AbstractEffectLoader(); ~AbstractEffectLoader() override;
/** /**
* @brief The KSharedConfig this EffectLoader should operate on. * @brief The KSharedConfig this EffectLoader should operate on.

@ -72,7 +72,7 @@ class KWIN_EXPORT EffectsHandlerImpl : public EffectsHandler
Q_PROPERTY(QStringList listOfEffects READ listOfEffects) Q_PROPERTY(QStringList listOfEffects READ listOfEffects)
public: public:
EffectsHandlerImpl(Compositor *compositor, Scene *scene); EffectsHandlerImpl(Compositor *compositor, Scene *scene);
virtual ~EffectsHandlerImpl(); ~EffectsHandlerImpl() override;
void prePaintScreen(ScreenPrePaintData& data, int time) override; void prePaintScreen(ScreenPrePaintData& data, int time) override;
void paintScreen(int mask, QRegion region, ScreenPaintData& data) override; void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
/** /**
@ -262,7 +262,7 @@ public:
return registered_atoms.contains(atom); return registered_atoms.contains(atom);
} }
void windowToDesktops(EffectWindow *w, const QVector<uint> &desktops); void windowToDesktops(EffectWindow *w, const QVector<uint> &desktops) override;
/** /**
* Finds an effect with the given name. * Finds an effect with the given name.
@ -490,8 +490,8 @@ public:
void elevate(bool elevate); void elevate(bool elevate);
void setData(int role, const QVariant &data); void setData(int role, const QVariant &data) override;
QVariant data(int role) const; QVariant data(int role) const override;
void registerThumbnail(AbstractThumbnailItem *item); void registerThumbnail(AbstractThumbnailItem *item);
QHash<WindowThumbnailItem*, QWeakPointer<EffectWindowImpl> > const &thumbnails() const { QHash<WindowThumbnailItem*, QWeakPointer<EffectWindowImpl> > const &thumbnails() const {
@ -534,7 +534,7 @@ class KWIN_EXPORT EffectFrameImpl
public: public:
explicit EffectFrameImpl(EffectFrameStyle style, bool staticSize = true, QPoint position = QPoint(-1, -1), explicit EffectFrameImpl(EffectFrameStyle style, bool staticSize = true, QPoint position = QPoint(-1, -1),
Qt::Alignment alignment = Qt::AlignCenter); Qt::Alignment alignment = Qt::AlignCenter);
virtual ~EffectFrameImpl(); ~EffectFrameImpl() override;
void free() override; void free() override;
void render(QRegion region = infiniteRegion(), double opacity = 1.0, double frameOpacity = 1.0) override; void render(QRegion region = infiniteRegion(), double opacity = 1.0, double frameOpacity = 1.0) override;

@ -32,9 +32,9 @@ class BlurEffectConfig : public KCModule
public: public:
explicit BlurEffectConfig(QWidget *parent = 0, const QVariantList& args = QVariantList()); explicit BlurEffectConfig(QWidget *parent = 0, const QVariantList& args = QVariantList());
~BlurEffectConfig(); ~BlurEffectConfig() override;
void save(); void save() override;
private: private:
::Ui::BlurEffectConfig ui; ::Ui::BlurEffectConfig ui;

@ -36,7 +36,7 @@ class ColorPickerEffect : public Effect, protected QDBusContext
Q_CLASSINFO("D-Bus Interface", "org.kde.kwin.ColorPicker") Q_CLASSINFO("D-Bus Interface", "org.kde.kwin.ColorPicker")
public: public:
ColorPickerEffect(); ColorPickerEffect();
virtual ~ColorPickerEffect(); ~ColorPickerEffect() override;
void paintScreen(int mask, QRegion region, ScreenPaintData &data) override; void paintScreen(int mask, QRegion region, ScreenPaintData &data) override;
void postPaintScreen() override; void postPaintScreen() override;
bool isActive() const override; bool isActive() const override;

@ -55,7 +55,7 @@ public:
void reconfigure(ReconfigureFlags) override; void reconfigure(ReconfigureFlags) override;
void prePaintScreen(ScreenPrePaintData &data, int time) override; void prePaintScreen(ScreenPrePaintData &data, int time) override;
void paintScreen(int mask, QRegion region, ScreenPaintData &data) override; void paintScreen(int mask, QRegion region, ScreenPaintData &data) override;
void postPaintScreen(); void postPaintScreen() override;
void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override; void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override;
void windowInputMouseEvent(QEvent *e) override; void windowInputMouseEvent(QEvent *e) override;
bool isActive() const override; bool isActive() const override;

@ -43,7 +43,7 @@ public:
explicit CoverSwitchEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit CoverSwitchEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private: private:
CoverSwitchEffectConfigForm* m_ui; CoverSwitchEffectConfigForm* m_ui;

@ -56,24 +56,24 @@ class CubeEffect
// TODO: electric borders: not a registered type // TODO: electric borders: not a registered type
public: public:
CubeEffect(); CubeEffect();
~CubeEffect(); ~CubeEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual bool borderActivated(ElectricBorder border); bool borderActivated(ElectricBorder border) override;
virtual void grabbedKeyboardEvent(QKeyEvent* e); void grabbedKeyboardEvent(QKeyEvent* e) override;
virtual void windowInputMouseEvent(QEvent* e); void windowInputMouseEvent(QEvent* e) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 50; return 50;
} }
// proxy functions // proxy functions
virtual void* proxy(); void* proxy() override;
void registerCubeInsideEffect(CubeInsideEffect* effect); void registerCubeInsideEffect(CubeInsideEffect* effect);
void unregisterCubeInsideEffect(CubeInsideEffect* effect); void unregisterCubeInsideEffect(CubeInsideEffect* effect);

@ -43,7 +43,7 @@ public:
explicit CubeEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit CubeEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private Q_SLOTS: private Q_SLOTS:
void capsSelectionChanged(); void capsSelectionChanged();

@ -29,7 +29,7 @@ class CubeInsideEffect : public Effect
{ {
public: public:
CubeInsideEffect() {} CubeInsideEffect() {}
virtual ~CubeInsideEffect() {} ~CubeInsideEffect() override {}
virtual void paint() = 0; virtual void paint() = 0;
virtual void setActive(bool active) = 0; virtual void setActive(bool active) = 0;

@ -40,14 +40,14 @@ class CubeSlideEffect
Q_PROPERTY(bool useWindowMoving READ isUseWindowMoving) Q_PROPERTY(bool useWindowMoving READ isUseWindowMoving)
public: public:
CubeSlideEffect(); CubeSlideEffect();
~CubeSlideEffect(); ~CubeSlideEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 50; return 50;

@ -43,7 +43,7 @@ public:
explicit CubeSlideEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit CubeSlideEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private: private:
CubeSlideEffectConfigForm* m_ui; CubeSlideEffectConfigForm* m_ui;

@ -67,17 +67,17 @@ class DesktopGridEffect
// TODO: electric borders // TODO: electric borders
public: public:
DesktopGridEffect(); DesktopGridEffect();
~DesktopGridEffect(); ~DesktopGridEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void windowInputMouseEvent(QEvent* e); void windowInputMouseEvent(QEvent* e) override;
virtual void grabbedKeyboardEvent(QKeyEvent* e); void grabbedKeyboardEvent(QKeyEvent* e) override;
virtual bool borderActivated(ElectricBorder border); bool borderActivated(ElectricBorder border) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 50; return 50;

@ -42,12 +42,12 @@ class DesktopGridEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit DesktopGridEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit DesktopGridEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~DesktopGridEffectConfig(); ~DesktopGridEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
virtual void load(); void load() override;
virtual void defaults(); void defaults() override;
private Q_SLOTS: private Q_SLOTS:
void layoutSelectionChanged(); void layoutSelectionChanged();

@ -33,12 +33,12 @@ class FallApartEffect
Q_PROPERTY(int blockSize READ configuredBlockSize) Q_PROPERTY(int blockSize READ configuredBlockSize)
public: public:
FallApartEffect(); FallApartEffect();
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 70; return 70;

@ -43,17 +43,17 @@ class FlipSwitchEffect
Q_PROPERTY(bool windowTitle READ isWindowTitle) Q_PROPERTY(bool windowTitle READ isWindowTitle)
public: public:
FlipSwitchEffect(); FlipSwitchEffect();
~FlipSwitchEffect(); ~FlipSwitchEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time); void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void grabbedKeyboardEvent(QKeyEvent* e); void grabbedKeyboardEvent(QKeyEvent* e) override;
virtual void windowInputMouseEvent(QEvent* e); void windowInputMouseEvent(QEvent* e) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 50; return 50;

@ -42,10 +42,10 @@ class FlipSwitchEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit FlipSwitchEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit FlipSwitchEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~FlipSwitchEffectConfig(); ~FlipSwitchEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private: private:
FlipSwitchEffectConfigForm* m_ui; FlipSwitchEffectConfigForm* m_ui;

@ -32,11 +32,11 @@ class HighlightWindowEffect
Q_OBJECT Q_OBJECT
public: public:
HighlightWindowEffect(); HighlightWindowEffect();
virtual ~HighlightWindowEffect(); ~HighlightWindowEffect() override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 70; return 70;

@ -38,12 +38,12 @@ class InvertEffect
Q_OBJECT Q_OBJECT
public: public:
InvertEffect(); InvertEffect();
~InvertEffect(); ~InvertEffect() override;
virtual void drawWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void drawWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void paintEffectFrame(KWin::EffectFrame* frame, QRegion region, double opacity, double frameOpacity); void paintEffectFrame(KWin::EffectFrame* frame, QRegion region, double opacity, double frameOpacity) override;
virtual bool isActive() const; bool isActive() const override;
virtual bool provides(Feature); bool provides(Feature) override;
int requestedEffectChainPosition() const override; int requestedEffectChainPosition() const override;

@ -33,12 +33,12 @@ class InvertEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit InvertEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit InvertEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~InvertEffectConfig(); ~InvertEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
virtual void load(); void load() override;
virtual void defaults(); void defaults() override;
private: private:
KShortcutsEditor* mShortcutEditor; KShortcutsEditor* mShortcutEditor;

@ -31,15 +31,15 @@ class KscreenEffect : public Effect
public: public:
KscreenEffect(); KscreenEffect();
virtual ~KscreenEffect(); ~KscreenEffect() override;
virtual void prePaintScreen(ScreenPrePaintData &data, int time); void prePaintScreen(ScreenPrePaintData &data, int time) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time); void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time) override;
virtual void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data); void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override;
void reconfigure(ReconfigureFlags flags); void reconfigure(ReconfigureFlags flags) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 99; return 99;

@ -41,13 +41,13 @@ class LookingGlassEffect : public Effect
Q_PROPERTY(int initialRadius READ initialRadius) Q_PROPERTY(int initialRadius READ initialRadius)
public: public:
LookingGlassEffect(); LookingGlassEffect();
virtual ~LookingGlassEffect(); ~LookingGlassEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
void paintScreen(int mask, QRegion region, ScreenPaintData &data) override; void paintScreen(int mask, QRegion region, ScreenPaintData &data) override;
virtual bool isActive() const; bool isActive() const override;
static bool supported(); static bool supported();

@ -42,10 +42,10 @@ class LookingGlassEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit LookingGlassEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit LookingGlassEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
virtual ~LookingGlassEffectConfig(); ~LookingGlassEffectConfig() override;
virtual void save(); void save() override;
virtual void defaults(); void defaults() override;
private: private:
LookingGlassEffectConfigForm* m_ui; LookingGlassEffectConfigForm* m_ui;

@ -34,12 +34,12 @@ class MagicLampEffect
public: public:
MagicLampEffect(); MagicLampEffect();
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 50; return 50;

@ -43,7 +43,7 @@ public:
explicit MagicLampEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit MagicLampEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private: private:
MagicLampEffectConfigForm* m_ui; MagicLampEffectConfigForm* m_ui;

@ -39,12 +39,12 @@ class MagnifierEffect
Q_PROPERTY(qreal targetZoom READ targetZoom) Q_PROPERTY(qreal targetZoom READ targetZoom)
public: public:
MagnifierEffect(); MagnifierEffect();
virtual ~MagnifierEffect(); ~MagnifierEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
static bool supported(); static bool supported();
// for properties // for properties

@ -42,10 +42,10 @@ class MagnifierEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit MagnifierEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit MagnifierEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
virtual ~MagnifierEffectConfig(); ~MagnifierEffectConfig() override;
virtual void save(); void save() override;
virtual void defaults(); void defaults() override;
private: private:
MagnifierEffectConfigForm* m_ui; MagnifierEffectConfigForm* m_ui;

@ -101,12 +101,12 @@ class MouseClickEffect
Q_PROPERTY(bool enabled READ isEnabled) Q_PROPERTY(bool enabled READ isEnabled)
public: public:
MouseClickEffect(); MouseClickEffect();
~MouseClickEffect(); ~MouseClickEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
// for properties // for properties
QColor color1() const { QColor color1() const {

@ -42,9 +42,9 @@ class MouseClickEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit MouseClickEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit MouseClickEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
virtual ~MouseClickEffectConfig(); ~MouseClickEffectConfig() override;
virtual void save(); void save() override;
private: private:
MouseClickEffectConfigForm* m_ui; MouseClickEffectConfigForm* m_ui;

@ -38,10 +38,10 @@ class MouseMarkEffect
Q_PROPERTY(QColor color READ configuredColor) Q_PROPERTY(QColor color READ configuredColor)
public: public:
MouseMarkEffect(); MouseMarkEffect();
~MouseMarkEffect(); ~MouseMarkEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual bool isActive() const; bool isActive() const override;
// for properties // for properties
int configuredWidth() const { int configuredWidth() const {

@ -42,9 +42,9 @@ class MouseMarkEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit MouseMarkEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit MouseMarkEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
virtual ~MouseMarkEffectConfig(); ~MouseMarkEffectConfig() override;
virtual void save(); void save() override;
private: private:
MouseMarkEffectConfigForm* m_ui; MouseMarkEffectConfigForm* m_ui;

@ -107,25 +107,25 @@ private:
public: public:
PresentWindowsEffect(); PresentWindowsEffect();
virtual ~PresentWindowsEffect(); ~PresentWindowsEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void* proxy(); void* proxy() override;
// Screen painting // Screen painting
virtual void prePaintScreen(ScreenPrePaintData &data, int time); void prePaintScreen(ScreenPrePaintData &data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData &data); void paintScreen(int mask, QRegion region, ScreenPaintData &data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
// Window painting // Window painting
virtual void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time); void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time) override;
virtual void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data); void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override;
// User interaction // User interaction
virtual bool borderActivated(ElectricBorder border); bool borderActivated(ElectricBorder border) override;
virtual void windowInputMouseEvent(QEvent *e); void windowInputMouseEvent(QEvent *e) override;
virtual void grabbedKeyboardEvent(QKeyEvent *e); void grabbedKeyboardEvent(QKeyEvent *e) override;
virtual bool isActive() const; bool isActive() const override;
bool touchDown(quint32 id, const QPointF &pos, quint32 time) override; bool touchDown(quint32 id, const QPointF &pos, quint32 time) override;
bool touchMotion(quint32 id, const QPointF &pos, quint32 time) override; bool touchMotion(quint32 id, const QPointF &pos, quint32 time) override;

@ -41,11 +41,11 @@ class PresentWindowsEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit PresentWindowsEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit PresentWindowsEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~PresentWindowsEffectConfig(); ~PresentWindowsEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
virtual void defaults(); void defaults() override;
private: private:
PresentWindowsEffectConfigForm* m_ui; PresentWindowsEffectConfigForm* m_ui;

@ -34,15 +34,15 @@ class ResizeEffect
Q_PROPERTY(bool outline READ isOutline) Q_PROPERTY(bool outline READ isOutline)
public: public:
ResizeEffect(); ResizeEffect();
~ResizeEffect(); ~ResizeEffect() override;
virtual inline bool provides(Effect::Feature ef) { inline bool provides(Effect::Feature ef) override {
return ef == Effect::Resize; return ef == Effect::Resize;
} }
inline bool isActive() const { return m_active || AnimationEffect::isActive(); } inline bool isActive() const override { return m_active || AnimationEffect::isActive(); }
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 60; return 60;

@ -43,7 +43,7 @@ public:
explicit ResizeEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit ResizeEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private: private:
ResizeEffectConfigForm* m_ui; ResizeEffectConfigForm* m_ui;

@ -35,10 +35,10 @@ class ScreenEdgeEffect : public Effect
Q_OBJECT Q_OBJECT
public: public:
ScreenEdgeEffect(); ScreenEdgeEffect();
virtual ~ScreenEdgeEffect(); ~ScreenEdgeEffect() override;
virtual void prePaintScreen(ScreenPrePaintData &data, int time); void prePaintScreen(ScreenPrePaintData &data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData &data); void paintScreen(int mask, QRegion region, ScreenPaintData &data) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 90; return 90;

@ -44,11 +44,11 @@ class ShowFpsEffect
Q_PROPERTY(QColor textColor READ configuredTextColor) Q_PROPERTY(QColor textColor READ configuredTextColor)
public: public:
ShowFpsEffect(); ShowFpsEffect();
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
enum { INSIDE_GRAPH, NOWHERE, TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT }; // fps text position enum { INSIDE_GRAPH, NOWHERE, TOP_LEFT, TOP_RIGHT, BOTTOM_LEFT, BOTTOM_RIGHT }; // fps text position
// for properties // for properties

@ -33,10 +33,10 @@ class ShowFpsEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit ShowFpsEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit ShowFpsEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~ShowFpsEffectConfig(); ~ShowFpsEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private: private:
Ui::ShowFpsEffectConfigForm *m_ui; Ui::ShowFpsEffectConfigForm *m_ui;

@ -34,9 +34,9 @@ class SlideEffectConfig : public KCModule
public: public:
explicit SlideEffectConfig(QWidget *parent = nullptr, const QVariantList &args = QVariantList()); explicit SlideEffectConfig(QWidget *parent = nullptr, const QVariantList &args = QVariantList());
~SlideEffectConfig(); ~SlideEffectConfig() override;
void save(); void save() override;
private: private:
::Ui::SlideEffectConfig m_ui; ::Ui::SlideEffectConfig m_ui;

@ -34,13 +34,13 @@ class SlideBackEffect
public: public:
SlideBackEffect(); SlideBackEffect();
virtual void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time); void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void postPaintWindow(EffectWindow* w); void postPaintWindow(EffectWindow* w) override;
virtual void prePaintScreen(ScreenPrePaintData &data, int time); void prePaintScreen(ScreenPrePaintData &data, int time) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 50; return 50;

@ -36,13 +36,13 @@ class StartupFeedbackEffect
Q_PROPERTY(int type READ type) Q_PROPERTY(int type READ type)
public: public:
StartupFeedbackEffect(); StartupFeedbackEffect();
virtual ~StartupFeedbackEffect(); ~StartupFeedbackEffect() override;
virtual void reconfigure(ReconfigureFlags flags); void reconfigure(ReconfigureFlags flags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 90; return 90;

@ -45,9 +45,9 @@ class ThumbnailAsideEffect
Q_PROPERTY(int screen READ configuredScreen) Q_PROPERTY(int screen READ configuredScreen)
public: public:
ThumbnailAsideEffect(); ThumbnailAsideEffect();
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data); void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override;
// for properties // for properties
int configuredMaxWidth() const { int configuredMaxWidth() const {
@ -67,7 +67,7 @@ private Q_SLOTS:
void slotWindowClosed(KWin::EffectWindow *w); void slotWindowClosed(KWin::EffectWindow *w);
void slotWindowGeometryShapeChanged(KWin::EffectWindow *w, const QRect &old); void slotWindowGeometryShapeChanged(KWin::EffectWindow *w, const QRect &old);
void slotWindowDamaged(KWin::EffectWindow* w, const QRect& damage); void slotWindowDamaged(KWin::EffectWindow* w, const QRect& damage);
virtual bool isActive() const; bool isActive() const override;
void repaintAll(); void repaintAll();
private: private:
void addThumbnail(EffectWindow* w); void addThumbnail(EffectWindow* w);

@ -42,9 +42,9 @@ class ThumbnailAsideEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit ThumbnailAsideEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit ThumbnailAsideEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
virtual ~ThumbnailAsideEffectConfig(); ~ThumbnailAsideEffectConfig() override;
virtual void save(); void save() override;
private: private:
ThumbnailAsideEffectConfigForm* m_ui; ThumbnailAsideEffectConfigForm* m_ui;

@ -37,7 +37,7 @@ class TouchPointsEffect
Q_PROPERTY(int ringCount READ ringCount) Q_PROPERTY(int ringCount READ ringCount)
public: public:
TouchPointsEffect(); TouchPointsEffect();
~TouchPointsEffect(); ~TouchPointsEffect() override;
void prePaintScreen(ScreenPrePaintData& data, int time) override; void prePaintScreen(ScreenPrePaintData& data, int time) override;
void paintScreen(int mask, QRegion region, ScreenPaintData& data) override; void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
void postPaintScreen() override; void postPaintScreen() override;

@ -39,12 +39,12 @@ class TrackMouseEffect
Q_PROPERTY(bool mousePolling READ isMousePolling) Q_PROPERTY(bool mousePolling READ isMousePolling)
public: public:
TrackMouseEffect(); TrackMouseEffect();
virtual ~TrackMouseEffect(); ~TrackMouseEffect() override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual bool isActive() const; bool isActive() const override;
// for properties // for properties
Qt::KeyboardModifiers modifiers() const { Qt::KeyboardModifiers modifiers() const {

@ -43,12 +43,12 @@ class TrackMouseEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit TrackMouseEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit TrackMouseEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~TrackMouseEffectConfig(); ~TrackMouseEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
virtual void load(); void load() override;
virtual void defaults(); void defaults() override;
private Q_SLOTS: private Q_SLOTS:
void shortcutChanged(const QKeySequence &seq); void shortcutChanged(const QKeySequence &seq);
private: private:

@ -33,14 +33,14 @@ class WindowGeometry : public Effect
Q_PROPERTY(bool handlesResizes READ isHandlesResizes) Q_PROPERTY(bool handlesResizes READ isHandlesResizes)
public: public:
WindowGeometry(); WindowGeometry();
~WindowGeometry(); ~WindowGeometry() override;
inline bool provides(Effect::Feature ef) { inline bool provides(Effect::Feature ef) override {
return ef == Effect::GeometryTip; return ef == Effect::GeometryTip;
} }
void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
void paintScreen(int mask, QRegion region, ScreenPaintData &data); void paintScreen(int mask, QRegion region, ScreenPaintData &data) override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
return 90; return 90;

@ -41,11 +41,11 @@ class WindowGeometryConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit WindowGeometryConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit WindowGeometryConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~WindowGeometryConfig(); ~WindowGeometryConfig() override;
public Q_SLOTS: public Q_SLOTS:
void save(); void save() override;
void defaults(); void defaults() override;
private: private:
WindowGeometryConfigForm* myUi; WindowGeometryConfigForm* myUi;

@ -44,14 +44,14 @@ class WobblyWindowsEffect : public Effect
public: public:
WobblyWindowsEffect(); WobblyWindowsEffect();
virtual ~WobblyWindowsEffect(); ~WobblyWindowsEffect() override;
virtual void reconfigure(ReconfigureFlags); void reconfigure(ReconfigureFlags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time); void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) override;
virtual void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data); void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
int requestedEffectChainPosition() const override { int requestedEffectChainPosition() const override {
// Please notice that the Wobbly Windows effect has to be placed // Please notice that the Wobbly Windows effect has to be placed

@ -35,10 +35,10 @@ class WobblyWindowsEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit WobblyWindowsEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit WobblyWindowsEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
~WobblyWindowsEffectConfig(); ~WobblyWindowsEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private Q_SLOTS: private Q_SLOTS:
void wobblinessChanged(); void wobblinessChanged();

@ -46,12 +46,12 @@ class ZoomEffect
Q_PROPERTY(qreal targetZoom READ targetZoom) Q_PROPERTY(qreal targetZoom READ targetZoom)
public: public:
ZoomEffect(); ZoomEffect();
virtual ~ZoomEffect(); ~ZoomEffect() override;
virtual void reconfigure(ReconfigureFlags flags); void reconfigure(ReconfigureFlags flags) override;
virtual void prePaintScreen(ScreenPrePaintData& data, int time); void prePaintScreen(ScreenPrePaintData& data, int time) override;
virtual void paintScreen(int mask, QRegion region, ScreenPaintData& data); void paintScreen(int mask, QRegion region, ScreenPaintData& data) override;
virtual void postPaintScreen(); void postPaintScreen() override;
virtual bool isActive() const; bool isActive() const override;
// for properties // for properties
qreal configuredZoomFactor() const { qreal configuredZoomFactor() const {
return zoomFactor; return zoomFactor;

@ -42,10 +42,10 @@ class ZoomEffectConfig : public KCModule
Q_OBJECT Q_OBJECT
public: public:
explicit ZoomEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList()); explicit ZoomEffectConfig(QWidget* parent = 0, const QVariantList& args = QVariantList());
virtual ~ZoomEffectConfig(); ~ZoomEffectConfig() override;
public Q_SLOTS: public Q_SLOTS:
virtual void save(); void save() override;
private: private:
ZoomEffectConfigForm* m_ui; ZoomEffectConfigForm* m_ui;

@ -55,7 +55,7 @@ public:
Update, Update,
MakeFirstMinimized = MakeFirst MakeFirstMinimized = MakeFirst
}; };
virtual ~FocusChain(); ~FocusChain() override;
/** /**
* @brief Updates the position of the @p client according to the requested @p change in the * @brief Updates the position of the @p client according to the requested @p change in the
* focus chain. * focus chain.

@ -32,7 +32,7 @@ class GeometryTip: public QLabel
Q_OBJECT Q_OBJECT
public: public:
GeometryTip(const Xcb::GeometryHints* xSizeHints); GeometryTip(const Xcb::GeometryHints* xSizeHints);
~GeometryTip(); ~GeometryTip() override;
void setGeometry(const QRect& geom); void setGeometry(const QRect& geom);
private: private:

@ -49,7 +49,7 @@ class GlobalShortcutsManager : public QObject
Q_OBJECT Q_OBJECT
public: public:
explicit GlobalShortcutsManager(QObject *parent = nullptr); explicit GlobalShortcutsManager(QObject *parent = nullptr);
virtual ~GlobalShortcutsManager(); ~GlobalShortcutsManager() override;
void init(); void init();
/** /**
@ -149,7 +149,7 @@ public:
InternalGlobalShortcut(Qt::KeyboardModifiers pointerButtonModifiers, Qt::MouseButtons pointerButtons, QAction *action); InternalGlobalShortcut(Qt::KeyboardModifiers pointerButtonModifiers, Qt::MouseButtons pointerButtons, QAction *action);
InternalGlobalShortcut(Qt::KeyboardModifiers axisModifiers, PointerAxisDirection axis, QAction *action); InternalGlobalShortcut(Qt::KeyboardModifiers axisModifiers, PointerAxisDirection axis, QAction *action);
InternalGlobalShortcut(Qt::KeyboardModifiers swipeModifier, SwipeDirection direction, QAction *action); InternalGlobalShortcut(Qt::KeyboardModifiers swipeModifier, SwipeDirection direction, QAction *action);
virtual ~InternalGlobalShortcut(); ~InternalGlobalShortcut() override;
void invoke() override; void invoke() override;

@ -44,7 +44,7 @@ class IdleInhibition : public QObject
Q_OBJECT Q_OBJECT
public: public:
explicit IdleInhibition(IdleInterface *idle); explicit IdleInhibition(IdleInterface *idle);
~IdleInhibition(); ~IdleInhibition() override;
void registerShellClient(ShellClient *client); void registerShellClient(ShellClient *client);

@ -92,7 +92,7 @@ public:
KeyboardKeyPressed, KeyboardKeyPressed,
KeyboardKeyAutoRepeat KeyboardKeyAutoRepeat
}; };
virtual ~InputRedirection(); ~InputRedirection() override;
void init(); void init();
/** /**
@ -378,7 +378,7 @@ class KWIN_EXPORT InputDeviceHandler : public QObject
{ {
Q_OBJECT Q_OBJECT
public: public:
virtual ~InputDeviceHandler(); ~InputDeviceHandler() override;
virtual void init(); virtual void init();
void update(); void update();

@ -140,7 +140,7 @@ public:
int columnCount(const QModelIndex &parent = QModelIndex()) const override; int columnCount(const QModelIndex &parent = QModelIndex()) const override;
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
virtual QHash< int, QByteArray > roleNames() const override; QHash< int, QByteArray > roleNames() const override;
Q_INVOKABLE int compositingTypeForIndex(int row) const; Q_INVOKABLE int compositingTypeForIndex(int row) const;
Q_INVOKABLE int indexForCompositingType(int type) const; Q_INVOKABLE int indexForCompositingType(int type) const;
@ -161,7 +161,7 @@ class OpenGLPlatformInterfaceModel : public QAbstractListModel
Q_OBJECT Q_OBJECT
public: public:
explicit OpenGLPlatformInterfaceModel(QObject *parent = nullptr); explicit OpenGLPlatformInterfaceModel(QObject *parent = nullptr);
virtual ~OpenGLPlatformInterfaceModel(); ~OpenGLPlatformInterfaceModel() override;
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
int rowCount(const QModelIndex &parent = QModelIndex()) const override; int rowCount(const QModelIndex &parent = QModelIndex()) const override;

@ -36,7 +36,7 @@ class ButtonsModel : public QAbstractListModel
public: public:
explicit ButtonsModel(const QVector< DecorationButtonType > &buttons, QObject *parent = 0); explicit ButtonsModel(const QVector< DecorationButtonType > &buttons, QObject *parent = 0);
explicit ButtonsModel(QObject *parent = nullptr); explicit ButtonsModel(QObject *parent = nullptr);
virtual ~ButtonsModel(); ~ButtonsModel() override;
QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override; QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
int rowCount(const QModelIndex& parent = QModelIndex()) const override; int rowCount(const QModelIndex& parent = QModelIndex()) const override;
QHash< int, QByteArray > roleNames() const override; QHash< int, QByteArray > roleNames() const override;

@ -45,7 +45,7 @@ class PreviewBridge : public DecorationBridge
Q_PROPERTY(bool valid READ isValid NOTIFY validChanged) Q_PROPERTY(bool valid READ isValid NOTIFY validChanged)
public: public:
explicit PreviewBridge(QObject *parent = nullptr); explicit PreviewBridge(QObject *parent = nullptr);
virtual ~PreviewBridge(); ~PreviewBridge() override;
std::unique_ptr<DecoratedClientPrivate> createClient(DecoratedClient *client, Decoration *decoration) override; std::unique_ptr<DecoratedClientPrivate> createClient(DecoratedClient *client, Decoration *decoration) override;
void update(Decoration* decoration, const QRect& geometry) override; void update(Decoration* decoration, const QRect& geometry) override;
std::unique_ptr<DecorationSettingsPrivate> settings(DecorationSettings *parent) override; std::unique_ptr<DecorationSettingsPrivate> settings(DecorationSettings *parent) override;
@ -99,7 +99,7 @@ class BridgeItem : public QObject
public: public:
explicit BridgeItem(QObject *parent = nullptr); explicit BridgeItem(QObject *parent = nullptr);
virtual ~BridgeItem(); ~BridgeItem() override;
void setPlugin(const QString &plugin) { void setPlugin(const QString &plugin) {
m_bridge->setPlugin(plugin); m_bridge->setPlugin(plugin);

@ -44,7 +44,7 @@ class PreviewButtonItem : public QQuickPaintedItem
public: public:
explicit PreviewButtonItem(QQuickItem *parent = nullptr); explicit PreviewButtonItem(QQuickItem *parent = nullptr);
virtual ~PreviewButtonItem(); ~PreviewButtonItem() override;
void paint(QPainter *painter) override; void paint(QPainter *painter) override;
PreviewBridge *bridge() const; PreviewBridge *bridge() const;

@ -64,7 +64,7 @@ class PreviewClient : public QObject, public ApplicationMenuEnabledDecoratedClie
Q_PROPERTY(bool bordersBottomEdge READ bordersBottomEdge WRITE setBordersBottomEdge NOTIFY bordersBottomEdgeChanged) Q_PROPERTY(bool bordersBottomEdge READ bordersBottomEdge WRITE setBordersBottomEdge NOTIFY bordersBottomEdgeChanged)
public: public:
explicit PreviewClient(DecoratedClient *client, Decoration *decoration); explicit PreviewClient(DecoratedClient *client, Decoration *decoration);
virtual ~PreviewClient(); ~PreviewClient() override;
QString caption() const override; QString caption() const override;
WId decorationId() const override; WId decorationId() const override;
@ -110,7 +110,7 @@ public:
void requestShowApplicationMenu(const QRect &rect, int actionId) override; void requestShowApplicationMenu(const QRect &rect, int actionId) override;
void requestToggleOnAllDesktops() override; void requestToggleOnAllDesktops() override;
void showApplicationMenu(int actionId); void showApplicationMenu(int actionId) override;
void setCaption(const QString &caption); void setCaption(const QString &caption);
void setActive(bool active); void setActive(bool active);

@ -47,8 +47,8 @@ class PreviewItem : public QQuickPaintedItem
Q_PROPERTY(bool drawBackground READ isDrawingBackground WRITE setDrawingBackground NOTIFY drawingBackgroundChanged) Q_PROPERTY(bool drawBackground READ isDrawingBackground WRITE setDrawingBackground NOTIFY drawingBackgroundChanged)
public: public:
PreviewItem(QQuickItem *parent = nullptr); PreviewItem(QQuickItem *parent = nullptr);
virtual ~PreviewItem(); ~PreviewItem() override;
void paint(QPainter *painter); void paint(QPainter *painter) override;
KDecoration2::Decoration *decoration() const; KDecoration2::Decoration *decoration() const;
void setDecoration(KDecoration2::Decoration *deco); void setDecoration(KDecoration2::Decoration *deco);

@ -38,7 +38,7 @@ class BorderSizesModel : public QAbstractListModel
Q_OBJECT Q_OBJECT
public: public:
explicit BorderSizesModel(QObject *parent = 0); explicit BorderSizesModel(QObject *parent = 0);
virtual ~BorderSizesModel(); ~BorderSizesModel() override;
QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override; QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
int rowCount(const QModelIndex& parent = QModelIndex()) const override; int rowCount(const QModelIndex& parent = QModelIndex()) const override;
QHash< int, QByteArray > roleNames() const override; QHash< int, QByteArray > roleNames() const override;
@ -70,7 +70,7 @@ class PreviewSettings : public QObject, public DecorationSettingsPrivate
Q_PROPERTY(QFont font READ font WRITE setFont NOTIFY fontChanged) Q_PROPERTY(QFont font READ font WRITE setFont NOTIFY fontChanged)
public: public:
explicit PreviewSettings(DecorationSettings *parent); explicit PreviewSettings(DecorationSettings *parent);
virtual ~PreviewSettings(); ~PreviewSettings() override;
bool isAlphaChannelSupported() const override; bool isAlphaChannelSupported() const override;
bool isOnAllDesktopsAvailable() const override; bool isOnAllDesktopsAvailable() const override;
bool isCloseOnDoubleClickOnMenu() const override { bool isCloseOnDoubleClickOnMenu() const override {
@ -100,7 +100,7 @@ public:
} }
void setBorderSizesIndex(int index); void setBorderSizesIndex(int index);
QFont font() const { QFont font() const override {
return m_font; return m_font;
} }
void setFont(const QFont &font); void setFont(const QFont &font);
@ -132,7 +132,7 @@ class Settings : public QObject
Q_PROPERTY(int borderSizesIndex READ borderSizesIndex WRITE setBorderSizesIndex NOTIFY borderSizesIndexChanged) Q_PROPERTY(int borderSizesIndex READ borderSizesIndex WRITE setBorderSizesIndex NOTIFY borderSizesIndexChanged)
public: public:
explicit Settings(QObject *parent = nullptr); explicit Settings(QObject *parent = nullptr);
virtual ~Settings(); ~Settings() override;
PreviewBridge *bridge() const; PreviewBridge *bridge() const;
void setBridge(PreviewBridge *bridge); void setBridge(PreviewBridge *bridge);

@ -43,7 +43,7 @@ public:
public: public:
explicit DecorationsModel(QObject *parent = nullptr); explicit DecorationsModel(QObject *parent = nullptr);
virtual ~DecorationsModel(); ~DecorationsModel() override;
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
int rowCount(const QModelIndex &parent = QModelIndex()) const override; int rowCount(const QModelIndex &parent = QModelIndex()) const override;

Some files were not shown because too many files have changed in this diff Show More

Loading…
Cancel
Save