You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371 |
5 years ago | |
|---|---|---|
| autotests | 5 years ago | |
| cmake/modules | 6 years ago | |
| colorcorrection | 5 years ago | |
| data | 5 years ago | |
| decorations | 5 years ago | |
| doc | 6 years ago | |
| effects | 5 years ago | |
| helpers | 5 years ago | |
| kcmkwin | 5 years ago | |
| kconf_update | 5 years ago | |
| libinput | 5 years ago | |
| libkwineffects | 5 years ago | |
| platformsupport | 5 years ago | |
| plugins | 5 years ago | |
| qml | ||
| scripting | 5 years ago | |
| scripts | 5 years ago | |
| tabbox | 5 years ago | |
| tests | 5 years ago | |
| xwl | 5 years ago | |
| .arcconfig | ||
| .arclint | ||
| CMakeLists.txt | 5 years ago | |
| COPYING | ||
| HACKING.md | 6 years ago | |
| KWinDBusInterfaceConfig.cmake.in | ||
| Mainpage.dox | ||
| Messages.sh | ||
| README.md | 6 years ago | |
| TESTING.md | 6 years ago | |
| abstract_client.cpp | 5 years ago | |
| abstract_client.h | 5 years ago | |
| abstract_opengl_context_attribute_builder.cpp | ||
| abstract_opengl_context_attribute_builder.h | ||
| abstract_output.cpp | 5 years ago | |
| abstract_output.h | 5 years ago | |
| abstract_wayland_output.cpp | 5 years ago | |
| abstract_wayland_output.h | 5 years ago | |
| activation.cpp | 5 years ago | |
| activities.cpp | ||
| activities.h | 5 years ago | |
| appmenu.cpp | ||
| appmenu.h | ||
| atoms.cpp | 6 years ago | |
| atoms.h | 6 years ago | |
| client.cpp | 5 years ago | |
| client.h | 5 years ago | |
| client_machine.cpp | ||
| client_machine.h | 5 years ago | |
| composite.cpp | 5 years ago | |
| composite.h | 5 years ago | |
| config-kwin.h.cmake | 6 years ago | |
| cursor.cpp | 6 years ago | |
| cursor.h | 5 years ago | |
| dbusinterface.cpp | 5 years ago | |
| dbusinterface.h | 5 years ago | |
| debug_console.cpp | 5 years ago | |
| debug_console.h | 5 years ago | |
| debug_console.ui | ||
| deleted.cpp | 6 years ago | |
| deleted.h | 5 years ago | |
| effectloader.cpp | ||
| effectloader.h | 5 years ago | |
| effects.cpp | 5 years ago | |
| effects.h | 5 years ago | |
| egl_context_attribute_builder.cpp | ||
| egl_context_attribute_builder.h | ||
| events.cpp | 5 years ago | |
| fixqopengl.h | ||
| focuschain.cpp | ||
| focuschain.h | 5 years ago | |
| geometry.cpp | 5 years ago | |
| geometrytip.cpp | ||
| geometrytip.h | 5 years ago | |
| gestures.cpp | ||
| gestures.h | 6 years ago | |
| globalshortcuts.cpp | ||
| globalshortcuts.h | 5 years ago | |
| group.cpp | 5 years ago | |
| group.h | ||
| idle_inhibition.cpp | 6 years ago | |
| idle_inhibition.h | 5 years ago | |
| input.cpp | 5 years ago | |
| input.h | 5 years ago | |
| input_event.cpp | 5 years ago | |
| input_event.h | 5 years ago | |
| input_event_spy.cpp | ||
| input_event_spy.h | ||
| internal_client.cpp | 5 years ago | |
| internal_client.h | 5 years ago | |
| keyboard_input.cpp | 6 years ago | |
| keyboard_input.h | 5 years ago | |
| keyboard_layout.cpp | 6 years ago | |
| keyboard_layout.h | ||
| keyboard_layout_switching.cpp | ||
| keyboard_layout_switching.h | 5 years ago | |
| keyboard_repeat.cpp | ||
| keyboard_repeat.h | ||
| killwindow.cpp | ||
| killwindow.h | ||
| kwin.kcfg | 5 years ago | |
| kwin.notifyrc | 5 years ago | |
| kwinbindings.cpp | 5 years ago | |
| layers.cpp | 5 years ago | |
| logind.cpp | 6 years ago | |
| logind.h | 5 years ago | |
| main.cpp | 5 years ago | |
| main.h | 5 years ago | |
| main_wayland.cpp | 5 years ago | |
| main_wayland.h | 5 years ago | |
| main_x11.cpp | 5 years ago | |
| main_x11.h | 5 years ago | |
| manage.cpp | 5 years ago | |
| modifier_only_shortcuts.cpp | ||
| modifier_only_shortcuts.h | ||
| moving_client_x11_filter.cpp | 5 years ago | |
| moving_client_x11_filter.h | ||
| netinfo.cpp | 5 years ago | |
| netinfo.h | 5 years ago | |
| onscreennotification.cpp | ||
| onscreennotification.h | ||
| options.cpp | 5 years ago | |
| options.h | 5 years ago | |
| org.kde.KWin.VirtualDesktopManager.xml | ||
| org.kde.KWin.xml | 6 years ago | |
| org.kde.kappmenu.xml | ||
| org.kde.kwin.ColorCorrect.xml | ||
| org.kde.kwin.Compositing.xml | ||
| org.kde.kwin.Effects.xml | ||
| org.kde.kwin.OrientationSensor.xml | ||
| orientation_sensor.cpp | 5 years ago | |
| orientation_sensor.h | 5 years ago | |
| osd.cpp | ||
| osd.h | ||
| outline.cpp | 6 years ago | |
| outline.h | 5 years ago | |
| outputscreens.cpp | 5 years ago | |
| outputscreens.h | 5 years ago | |
| overlaywindow.cpp | ||
| overlaywindow.h | ||
| placement.cpp | 5 years ago | |
| placement.h | 6 years ago | |
| platform.cpp | 5 years ago | |
| platform.h | 5 years ago | |
| pointer_input.cpp | 5 years ago | |
| pointer_input.h | 5 years ago | |
| popup_input_filter.cpp | ||
| popup_input_filter.h | ||
| rootinfo_filter.cpp | ||
| rootinfo_filter.h | ||
| rules.cpp | 5 years ago | |
| rules.h | 5 years ago | |
| scene.cpp | 6 years ago | |
| scene.h | 5 years ago | |
| screenedge.cpp | 5 years ago | |
| screenedge.h | 5 years ago | |
| screenlockerwatcher.cpp | 5 years ago | |
| screenlockerwatcher.h | 5 years ago | |
| screens.cpp | 5 years ago | |
| screens.h | 5 years ago | |
| settings.kcfgc | ||
| shadow.cpp | 5 years ago | |
| shadow.h | 5 years ago | |
| shell_client.cpp | 5 years ago | |
| shell_client.h | 5 years ago | |
| shortcutdialog.ui | ||
| sm.cpp | 5 years ago | |
| sm.h | 5 years ago | |
| tabgroup.cpp | ||
| tabgroup.h | 6 years ago | |
| tabletmodemanager.cpp | 6 years ago | |
| tabletmodemanager.h | 5 years ago | |
| thumbnailitem.cpp | 5 years ago | |
| thumbnailitem.h | 5 years ago | |
| toplevel.cpp | 5 years ago | |
| toplevel.h | 5 years ago | |
| touch_hide_cursor_spy.cpp | ||
| touch_hide_cursor_spy.h | ||
| touch_input.cpp | ||
| touch_input.h | 5 years ago | |
| udev.cpp | 6 years ago | |
| udev.h | 6 years ago | |
| unmanaged.cpp | 6 years ago | |
| unmanaged.h | 5 years ago | |
| useractions.cpp | 5 years ago | |
| useractions.h | 5 years ago | |
| utils.cpp | 5 years ago | |
| utils.h | 5 years ago | |
| virtual_terminal.cpp | 5 years ago | |
| virtual_terminal.h | 5 years ago | |
| virtualdesktops.cpp | 6 years ago | |
| virtualdesktops.h | 5 years ago | |
| virtualdesktopsdbustypes.cpp | ||
| virtualdesktopsdbustypes.h | ||
| virtualkeyboard.cpp | 6 years ago | |
| virtualkeyboard.h | 5 years ago | |
| virtualkeyboard_dbus.cpp | ||
| virtualkeyboard_dbus.h | 5 years ago | |
| was_user_interaction_x11_filter.cpp | ||
| was_user_interaction_x11_filter.h | ||
| wayland_cursor_theme.cpp | ||
| wayland_cursor_theme.h | 5 years ago | |
| wayland_server.cpp | 5 years ago | |
| wayland_server.h | 5 years ago | |
| window_property_notify_x11_filter.cpp | ||
| window_property_notify_x11_filter.h | ||
| workspace.cpp | 5 years ago | |
| workspace.h | 5 years ago | |
| x11eventfilter.cpp | ||
| x11eventfilter.h | 6 years ago | |
| xcbutils.cpp | 5 years ago | |
| xcbutils.h | 5 years ago | |
| xkb.cpp | ||
| xkb.h | 5 years ago | |
| xkb_qt_mapping.h | ||
README.md
KWin
KWin is an easy to use, but flexible, composited Window Manager for Xorg windowing systems (Wayland, X11) on Linux. Its primary usage is in conjunction with a Desktop Shell (e.g. KDE Plasma Desktop). KWin is designed to go out of the way; users should not notice that they use a window manager at all. Nevertheless KWin provides a steep learning curve for advanced features, which are available, if they do not conflict with the primary mission. KWin does not have a dedicated targeted user group, but follows the targeted user group of the Desktop Shell using KWin as it's window manager.
KWin is not...
- a standalone window manager (c.f. openbox, i3) and does not provide any functionality belonging to a Desktop Shell.
- a replacement for window managers designed for use with a specific Desktop Shell (e.g. GNOME Shell)
- a minimalistic window manager
- designed for use without compositing or for X11 network transparency, though both are possible.
Contacting KWin development team
- mailing list: kwin@kde.org
- IRC: #kwin on freenode
Support
Application Developer
If you are an application developer having questions regarding windowing systems (either X11 or Wayland) please do not hesitate to contact us. Preferable through our mailing list. Ideally subscribe to the mailing list, so that your mail doesn't get stuck in the moderation queue.
End user
Please contact the support channels of your Linux distribution for user support. The KWin development team does not provide end user support.
Reporting bugs
Please use KDE's bugtracker and report for product KWin.
Developing on KWin
Please refer to hacking documentation for how to build and start KWin. Further information about KWin's test suite can be found in TESTING.md.
Guidelines for new features
A new Feature can only be added to KWin if:
- it does not violate the primary missions as stated at the start of this document
- it does not introduce instabilities
- it is maintained, that is bugs are fixed in a timely manner (second next minor release) if it is not a corner case.
- it works together with all existing features
- it supports both single and multi screen (xrandr)
- it adds a significant advantage
- it is feature complete, that is supports at least all useful features from competitive implementations
- it is not a special case for a small user group
- it does not increase code complexity significantly
- it does not affect KWin's license (GPLv2+)
All new added features are under probation, that is if any of the non-functional requirements as listed above do not hold true in the next two feature releases, the added feature will be removed again.
The same non functional requirements hold true for any kind of plugins (effects, scripts, etc.). It is suggested to use scripted plugins and distribute them separately.