You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
8af2fa73dc
Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371 |
5 years ago | |
|---|---|---|
| .. | ||
| CMakeLists.txt | 5 years ago | |
| abstractplatformcontext.cpp | 5 years ago | |
| abstractplatformcontext.h | 5 years ago | |
| backingstore.cpp | 5 years ago | |
| backingstore.h | 5 years ago | |
| eglhelpers.cpp | 5 years ago | |
| eglhelpers.h | 5 years ago | |
| integration.cpp | 5 years ago | |
| integration.h | 5 years ago | |
| kwin.json | 9 years ago | |
| main.cpp | 7 years ago | |
| nativeinterface.cpp | 5 years ago | |
| nativeinterface.h | 9 years ago | |
| offscreensurface.cpp | 5 years ago | |
| offscreensurface.h | 5 years ago | |
| platformcursor.cpp | 9 years ago | |
| platformcursor.h | 5 years ago | |
| screen.cpp | 5 years ago | |
| screen.h | 5 years ago | |
| sharingplatformcontext.cpp | 5 years ago | |
| sharingplatformcontext.h | 5 years ago | |
| window.cpp | 5 years ago | |
| window.h | 5 years ago | |