You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 
Alex Nemeth 99532fb95c Fix multimonitor blur
Summary:
On wayland blur on secondary monitor would not render correctly.

BUG: 393723
Depends on D12452

Test Plan:
 - use more than one output
 - log in in a wayland session
 - open a transparent window (for example: Konsole with transparent and blur enabled profile)
 - drag the window to another screen
 - blurs the content under the window corretly

Reviewers: #kwin, graesslin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: apol, zzag, davidedmundson, kwin, #kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D12678
6 years ago
autotests Merge branch 'Plasma/5.13' 6 years ago
cmake/modules [autotests] Add tests for DRM platform plugin 7 years ago
colorcorrection [colorcorrection] Apply current color temperature on screen hot plug 7 years ago
data Move SceneOpenGL into a dedicated plugin 7 years ago
decorations Improve tooltips behavior 7 years ago
doc Update kwindecoration docbook 7 years ago
effects Fix multimonitor blur 6 years ago
helpers
kcmkwin Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
libinput libinput/connection: Don't hardcode seat0 anymore 7 years ago
libkwineffects [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer 6 years ago
packageplugins SVN_SILENT made messages (.desktop file) - always resolve ours 7 years ago
platformsupport Request a high-priority EGL contexts 7 years ago
plugins Merge branch 'Plasma/5.13' 6 years ago
qml
scripting Fix message extraction 6 years ago
scripts SVN_SILENT made messages (.desktop file) - always resolve ours 6 years ago
shaders
tabbox [TabBox] Don't show "Show desktop" window when cycling through application windows 7 years ago
tests Require libinput and udev 7 years ago
.arcconfig
16-apps-kwin.png
32-apps-kwin.png
48-apps-kwin.png
CMakeLists.txt Update version number for 5.13.80 6 years ago
COMPLIANCE
CONFIGURING
COPYING
COPYING.DOC Put licence files on each repo, removing from root. 11 years ago
ExtraDesktop.sh
HACKING
KWinDBusInterfaceConfig.cmake.in
Mainpage.dox
Messages.sh Fix message extraction 6 years ago
README
abstract_client.cpp Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
abstract_client.h Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
abstract_opengl_context_attribute_builder.cpp Request a high-priority EGL contexts 7 years ago
abstract_opengl_context_attribute_builder.h Request a high-priority EGL contexts 7 years ago
activation.cpp Drop no longer needed cast to Client in TabGroup related code 6 years ago
activities.cpp
activities.h
appmenu.cpp Don't try to open application menu when client doesn't have one 7 years ago
appmenu.h export org.kde.appmenuview 7 years ago
atoms.cpp
atoms.h
client.cpp Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
client.h Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
client_machine.cpp
client_machine.h
composite.cpp Simplify compositing setup code 7 years ago
composite.h Drop the explicit fallback to XRender 7 years ago
config-kwin.h.cmake Require libinput and udev 7 years ago
cursor.cpp Improve cursor size setup 6 years ago
cursor.h Move XFixes cursor change tracking into the x11 standalone platform 7 years ago
dbusinterface.cpp Add a new desktopfile name rule 7 years ago
dbusinterface.h Add a method to dbus interface to query information about a window 7 years ago
debug_console.cpp Require libinput and udev 7 years ago
debug_console.h Require libinput and udev 7 years ago
debug_console.ui
deleted.cpp
deleted.h
effectloader.cpp
effectloader.h
effects.cpp Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin 7 years ago
effects.h Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin 7 years ago
egl_context_attribute_builder.cpp Request a high-priority EGL contexts 7 years ago
egl_context_attribute_builder.h [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context 7 years ago
events.cpp Create a dedicated X11Filter for Client sync events and move it to X11 platform 7 years ago
fixqopengl.h Fix the build on armhf/aarch64 7 years ago
focuschain.cpp
focuschain.h
geometry.cpp Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked 7 years ago
geometrytip.cpp
geometrytip.h
gestures.cpp
gestures.h
globalshortcuts.cpp Don't try to filter null key combinations 7 years ago
globalshortcuts.h Drop unused private field GlobalShortcut::m_axis 7 years ago
group.cpp From 22% of cpu in hasTransientInternal to 0.2x% 7 years ago
group.h
idle_inhibition.cpp Fix possible heap-use-after-free in idle inhibition handling 7 years ago
idle_inhibition.h Fix possible heap-use-after-free in idle inhibition handling 7 years ago
input.cpp Ensure the QToolTip on the deocration does not steal key events 6 years ago
input.h Expose if the tablet mode switch is available 7 years ago
input_event.cpp Pass SwitchEvent from LibInput through KWin and add to DebugConsole 7 years ago
input_event.h Pass SwitchEvent from LibInput through KWin and add to DebugConsole 7 years ago
input_event_spy.cpp Pass SwitchEvent from LibInput through KWin and add to DebugConsole 7 years ago
input_event_spy.h Pass SwitchEvent from LibInput through KWin and add to DebugConsole 7 years ago
keyboard_input.cpp Dependency inject KWayland::Server::SeatInterface into Xkb 7 years ago
keyboard_input.h Split KWin::Xkb into a dedicated .h and .cpp 8 years ago
keyboard_layout.cpp Fix warning 7 years ago
keyboard_layout.h
keyboard_layout_switching.cpp
keyboard_layout_switching.h
keyboard_repeat.cpp
keyboard_repeat.h
killwindow.cpp
killwindow.h
kwin.kcfg
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 7 years ago
kwinbindings.cpp Expose more default window management shortcuts 7 years ago
lanczosfilter.cpp Raise minimum required Mesa version to 10.0 7 years ago
lanczosfilter.h Move SceneOpenGL into a dedicated plugin 7 years ago
layers.cpp Keep fullscreen windows in active layer based on transients not the group 7 years ago
logind.cpp logind: Add a function that detects the logind seat. 7 years ago
logind.h logind: Add a function that detects the logind seat. 7 years ago
main.cpp Require libinput and udev 7 years ago
main.h Drop OperationModeX11AndWayland and introduce OperationModeWaylandOnly instead 7 years ago
main_wayland.cpp Disallow running KWin/Wayland as root 6 years ago
main_wayland.h Ensure Workspace is only started once in Wayland-only mode 7 years ago
main_x11.cpp Load QtQuick settings 7 years ago
main_x11.h
manage.cpp Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
modifier_only_shortcuts.cpp
modifier_only_shortcuts.h
moving_client_x11_filter.cpp Move X11 movingClient handling into a dedicated X11EventFilter 7 years ago
moving_client_x11_filter.h Move X11 movingClient handling into a dedicated X11EventFilter 7 years ago
netinfo.cpp Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
netinfo.h Create a dedicated X11EventFilter for the events used by RootInfo 7 years ago
onscreennotification.cpp Drop invalid .moc file inclusion 7 years ago
onscreennotification.h
options.cpp Try all supported Compositor Types of the current Platform 7 years ago
options.h Move XRandR event filter into XRandRScreens 7 years ago
org.freedesktop.ScreenSaver.xml
org.kde.KWin.xml Add a method to dbus interface to query information about a window 7 years ago
org.kde.kappmenu.xml
org.kde.kwin.ColorCorrect.xml [colorcorrection] Night Color - blue light filter at nighttime 7 years ago
org.kde.kwin.Compositing.xml [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required 8 years ago
org.kde.kwin.Effects.xml
org.kde.kwin.OrientationSensor.xml Add DBus interface to OrientationSensor and a persistent configuration 7 years ago
orientation_sensor.cpp Add DBus interface to OrientationSensor and a persistent configuration 7 years ago
orientation_sensor.h Add DBus interface to OrientationSensor and a persistent configuration 7 years ago
osd.cpp
osd.h
outline.cpp Move NonComposited Outline into the X11 standalone platform 7 years ago
outline.h Move NonComposited Outline into the X11 standalone platform 7 years ago
overlaywindow.cpp Move the X11 specific OverlayWindow into the platform/x11 7 years ago
overlaywindow.h Move the X11 specific OverlayWindow into the platform/x11 7 years ago
placement.cpp Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument 7 years ago
placement.h
platform.cpp Add environment variable to force sw cursor 7 years ago
platform.h Fix the build on armhf/aarch64 7 years ago
pointer_input.cpp Merge branch 'Plasma/5.12' into Plasma/5.13 6 years ago
pointer_input.h Ensure leave event is send to decoration when a window maximizes 7 years ago
popup_input_filter.cpp
popup_input_filter.h
resources.qrc
rootinfo_filter.cpp Create a dedicated X11EventFilter for the events used by RootInfo 7 years ago
rootinfo_filter.h Create a dedicated X11EventFilter for the events used by RootInfo 7 years ago
rules.cpp Use existing KSharedConfig in RuleBook::save 6 years ago
rules.h Merge branch 'Plasma/5.12' into Plasma/5.13 6 years ago
sc-apps-kwin.svgz
scene.cpp [Scene] Port from QRegion::rects() to QRegion iterators 7 years ago
scene.h Render GL Window decorations at the correct scale 7 years ago
screenedge.cpp Port some displayWidth/displayHeight usages to Screens::size() 7 years ago
screenedge.h Move X11 specific event filtering for ScreenEdges into x11 standalone platform 7 years ago
screenlockerwatcher.cpp
screenlockerwatcher.h
screens.cpp Add DBus interface to OrientationSensor and a persistent configuration 7 years ago
screens.h Add DBus interface to OrientationSensor and a persistent configuration 7 years ago
settings.kcfgc
shadow.cpp Only try creating X11 shadow if we have an X11 connection 7 years ago
shadow.h Move SceneXRender into a plugin 7 years ago
shell_client.cpp Revert "Revert "Add "SkipSwitcher" to API"" 6 years ago
shell_client.h Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked 7 years ago
shortcutdialog.ui
sm.cpp
sm.h
tabgroup.cpp Port TabGroup from Client to AbstractClient 6 years ago
tabgroup.h Move TabGroup functionality from Client to AbstractClient 6 years ago
tabletmodemanager.cpp Remove remaining HAVE_INPUT ifdef sections 7 years ago
tabletmodemanager.h Expose if the tablet mode switch is available 7 years ago
thumbnailitem.cpp
thumbnailitem.h
toplevel.cpp Render GL Window decorations at the correct scale 7 years ago
toplevel.h Render GL Window decorations at the correct scale 7 years ago
touch_input.cpp
touch_input.h
udev.cpp udev: Only handle devices from the current seat 7 years ago
udev.h udev: Add the ability to query the current framebuffer. 7 years ago
unmanaged.cpp Implement addDamage in Unmanaged 8 years ago
unmanaged.h
useractions.cpp Use AbstractClient in UserActionsMenu for tab functionality 6 years ago
useractions.h Disable window rule configuration for Wayland 7 years ago
utils.cpp Drop unused functions from utils 7 years ago
utils.h Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin 7 years ago
virtual_terminal.cpp
virtual_terminal.h
virtualdesktops.cpp
virtualdesktops.h Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager 7 years ago
virtualkeyboard.cpp Add DBus protocol to virtual keyboard 7 years ago
virtualkeyboard.h Add DBus protocol to virtual keyboard 7 years ago
virtualkeyboard_dbus.cpp Add DBus protocol to virtual keyboard 7 years ago
virtualkeyboard_dbus.h Add DBus protocol to virtual keyboard 7 years ago
was_user_interaction_x11_filter.cpp Create a dedicated X11EventFilter for recognizing first user interaction 7 years ago
was_user_interaction_x11_filter.h Create a dedicated X11EventFilter for recognizing first user interaction 7 years ago
wayland_cursor_theme.cpp Improve cursor size setup 6 years ago
wayland_cursor_theme.h
wayland_server.cpp Add XDG Output support 6 years ago
wayland_server.h Add XDG Output support 6 years ago
window_property_notify_x11_filter.cpp Add a dedicated X11EventFilter for forwarding property events to the effect system 7 years ago
window_property_notify_x11_filter.h Add a dedicated X11EventFilter for forwarding property events to the effect system 7 years ago
workspace.cpp Merge branch 'Plasma/5.12' 7 years ago
workspace.h Merge branch 'Plasma/5.11' 7 years ago
x11eventfilter.cpp
x11eventfilter.h
xcbutils.cpp
xcbutils.h
xkb.cpp Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account 7 years ago
xkb.h Support mapping QKeyEvent to xkb_keysym_t 7 years ago
xkb_qt_mapping.h Support mapping QKeyEvent to xkb_keysym_t 7 years ago

README

- A collection of various documents and links related to KWin is at http://techbase.kde.org/Projects/KWin .


- The mailing list for KWin is kwin@kde.org (https://mail.kde.org/mailman/listinfo/kwin).

- If you want to develop KWin, see file HACKING.

- If you want to check KWin's compliance with specifications, see file COMPLIANCE.

- File CONFIGURATION includes some details on configuring KWin.

- Below is some info for application developers about application interaction
  with the window manager, but it'd need some cleanup.








 This README is meant as an explanation of various window manager related
mechanisms that application developers need to be aware of. As some of these
concepts may be difficult to understand for people not having the required
background knowledge (since sometimes it's difficult even for people who
do have the knowledge), the mechanisms are first briefly explained, and
then an example of fixing the various problems is given.

 For comments, questions, suggestions and whatever use the kwin@kde.org
mailing list.


Table of contents:
==================

- Window relations
    - how to make the window manager know which windows belong together
- Focus stealing prevention
    - how to solve cases where focus stealing prevention doesn't work
      properly automatically



Window relations:
=================

(For now, this explanation of window relations is mainly meant for
focus stealing prevention. To be extended later.)

 All windows created by an application should be organized in a tree
with the root being the application's main window. Note that this is about
toplevel windows, not widgets inside the windows. For example, if you
have KWrite running, with a torn-off toolbar (i.e. a standalone toolbar),
a file save dialog open, and the file save dialog showing a dialog
for creating a directory, the window hiearchy should look like this:


             KWrite mainwindow
              /             \
             /               \
      file save dialog      torn-off toolbar
            \
             \
          create directory dialog

 Each subwindow (i.e. all except for the KWrite mainwindow) points to its
main window (which in turn may have another main window, as in the case
of the file save dialog). When the window manager knows these relations,
it can better arrange the windows (keeping subwindows above their
main windows, preventing activation of a main window of a modal dialog,
and similar). Failing to provide this information to the window manager
may have various results, for example having dialogs positioned below
the main window,

The window property used by subwindows to point to their mainwindows is
called WM_TRANSIENT_FOR. It can be seen by running
'xprop | grep WM_TRANSIENT_FOR' and clicking on a window. If the property
is not present, the window does not (claim to) have any mainwindow.
If the property is present, it's value is the window id of its main window;
window id of any window can be found out by running 'xwininfo'. A window
having WM_TRANSIENT_FOR poiting to another window is said to be transient
for that window.

 In some cases, the WM_TRANSIENT_FOR property may not point to any other
existing window, having value of 0, or pointing to the screen number
('xwininfo -root'). These special values mean that the window is transient
for all other windows in its window group. This should be used only
in rare cases, everytime a specific main window is known, WM_TRANSIENT_FOR
should be pointing to it instead of using one of these special values.
(The explanation why is beyond the scope of this document - just accept it
as a fact.)

 With Qt, the WM_TRANSIENT_FOR property is set by Qt automatically, based
on the toplevel widget's parent. If the toplevel widget is of a normal
type (i.e. not a dialog, toolbar, etc.), Qt doesn't set WM_TRANSIENT_FOR
on it. For special widgets, such as dialogs, WM_TRANSIENT_FOR is set
to point to the widget's parent, if it has a specific parent, otherwise
WM_TRANSIENT_FOR points to the root window.

 As already said above, WM_TRANSIENT_FOR poiting to the root window should
be usually avoided, so everytime the widget's main widget is known, the widget
should get it passed as a parent in its constructor.
(TODO KDialog etc. classes should not have a default argument for the parent
argument, and comments like 'just pass 0 as the parent' should go.)



Focus stealing prevention:
==========================

 Since KDE3.2 KWin has a feature called focus stealing prevention. As the name
suggests, it prevents unexpected changes of focus. With older versions of KWin,
if any application opened a new dialog, it became active, and
if the application's main window was on another virtual desktop, also
the virtual desktop was changed. This was annoying, and also sometimes led
to dialogs mistakenly being closed because they received keyboard input that
was meant for the previously active window.

 The basic principle of focus stealing prevention is that the window with most
recent user activity wins. Any window of an application will become active
when being shown only if this application was the most recently used one.
KWin itself, and some of the related kdecore classes should take care
of the common cases, so usually there's no need for any special handling
in applications. Qt/KDE applications, that is. Applications using other
toolkits should in most cases work fine too. If they don't support
the window property _NET_WM_USER_TIME, the window manager may fail to detect
the user timestamp properly, resulting either in other windows becoming active
while the user works with this application, or this application may sometimes
steal focus (this second case should be very rare though).

 There are also cases where KDE applications needs special handling. The two
most common cases are when windows relations are not setup properly to make
KWin realize that they belong to the same application, and when the user
activity is not represented by manipulating with the application windows
themselves.

 Also note that focus stealing prevention implemented in the window manager
can only help with focus stealing between different applications.
If an application itself suddenly pops up a dialog, KWin cannot do anything about
it, and its the application's job to handle this case.


Window relations:
-----------------

 The common case here is when a dialog is shown for an application, but this
dialog is not provided by the application itself, but by some other process.
For example, dialogs with warnings about accepted cookies are provided
by KCookieJar, instead of being shown by Konqueror. In the normal case,
from KWin's point of view the cookie dialog would be an attempt of another
application to show a dialog, and KWin wouldn't allow activation of this
window.

 The solution is to tell the window manager about the relation between
the Konqueror main window and the cookie dialog, by making the dialog
point to the mainwindow. Note that this is not special to focus stealing
prevention, subwindows such as dialogs, toolbars and similar should always
point to their mainwindow. See the section on window relations for full
description.

 The WM_TRANSIENT_FOR property that's set on dialogs to point to their
mainwindow should in the cookie dialog case point to the Konqueror window
for which it has been shown. This is solved in kcookiejar by including
the window id in the DCOP call. When the cookie dialog is shown, its
WM_TRANSIENT_FOR property is manually set using the XSetTransientForHint()
call (see kdelibs/kioslave/http/kcookiejar/kcookiewin.cpp). The arguments
to XSetTransientForHint() call are the X display (i.e. QX11Info::display()),
the window id on which the WM_TRANSIENT_FOR property is to be set
(i.e. use QWidget::winId()), and the window id of the mainwindow.


  Simple short HOWTO:
  
 To put it simply: Let's say you have a daemon application that has
DCOP call "showDialog( QString text )", and when this is called, it shows
a dialog with the given text. This won't work properly with focus stealing
prevention. The DCOP call should be changed to
"showDialog( QString text, long id )". The caller should pass something like
myMainWindow->winId() as the second argument. In the daemon, before
the dialog is shown, a call to XSetTransientHint() should be added:

 XSetTransientForHint( QX11Info::display(), dialog->winId(), id_of_mainwindow );
 
 That's it.

Non-standard user activity:
---------------------------

 The most common case in KDE will be DCOP calls. For example, KDesktop's DCOP
call "KDesktopIface popupExecuteCommand". Executing this DCOP call e.g.
from Konsole as 'dcop kdesktop KDesktopIface popupExecuteCommand" will lead
to showing the minicli, but the last user activity timestamp gained from events
sent by X server will be older than user activity timestamp of Konsole, and
would normally result in minicli not being active. Therefore, before showing
the minicli, kdesktop needs to call KApplication::updateUserTimestamp().

 However, this shouldn't be done with all DCOP calls. If a DCOP call is not
a result of direct user action, calling KApplication::updateUserTimestamp()
would lead to focus stealing. For example, let's assume for a moment
that KMail would use this DCOP call in case it detects the modem is not
connected, allowing to you to start KPPP or whatever tool you use. If KMail
would be configured to check mail every 10 minutes, this would lead to minicli
possibly suddenly showing up at every check. Basically, doing the above change
to kdesktop's minicli means that the popupExecuteCommand() DCOP call is only
for user scripting. (TODO write about focus transferring?)

 Simply said, KApplication::updateUserTimestamp() should be called only
as a result of user action. Unfortunately, I'm not aware of any universal
way how to handle this, so every case will have to be considered separately.