You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
a281f2bce1
Summary: If a modal window is closed and some alternative effect that animates the disappearing of windows is enabled(e.g. the Glide effect, or the Scale effect), the Dialog Parent effect can cause flickering of the parent window because its animation duration doesn't match duration of those alternative effects. Also, if the Fade effect, the Glide effect, and the Scale effect are disabled, the Dialog Parent will keep the parent window alive for no good reason. This change addresses that problem by adding keepAlive property to `animate` function so scripted effects have more control over lifetime of animated windows. If both a modal window and its parent window are closed at the same time (and there is no effect that animates the disappearing of windows), the Dialog Parent will stop immediately(because windowDeleted will be emitted right after windowClosed signal). If both a modal window and its parent window are closed at the same time (and there is effect that animates the disappearing of windows), the Dialog Parent won't reference the latter window. Thus, it won't cause flickering. I.e. it will "passively" animate parent windows. BUG: 355036 FIXED-IN: 5.15.0 Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D14919 |
6 years ago | |
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| Messages.sh | ||
| dbuscall.cpp | ||
| dbuscall.h | ||
| documentation-effect-global.xml | ||
| documentation-global.xml | ||
| genericscriptedconfig.cpp | ||
| genericscriptedconfig.h | ||
| genericscriptedconfig.json | ||
| kwinscript.desktop | ||
| meta.cpp | ||
| meta.h | ||
| screenedgeitem.cpp | ||
| screenedgeitem.h | ||
| scriptedeffect.cpp | 6 years ago | |
| scriptedeffect.h | 6 years ago | |
| scripting.cpp | ||
| scripting.h | ||
| scripting_logging.cpp | ||
| scripting_logging.h | ||
| scripting_model.cpp | ||
| scripting_model.h | ||
| scriptingutils.cpp | ||
| scriptingutils.h | ||
| timer.cpp | ||
| workspace_wrapper.cpp | ||
| workspace_wrapper.h | ||