You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
defa1061af
Summary: The Dim Inactive effect sees the world a little bit differently. m_activeWindow is currently active window that can be dimmed later on. In most cases, it's the same as effects->activeWindow(). In rare cases, it can be nullptr, even when effects->activeWindow() is not equal to nullptr (e.g. when active window is a context menu popup). canDimWindow is a helper that returns true if a given window should be dimmed, otherwise it returns false. It has one special case: if a given window is equal to m_activeWindow, return false. I.e. don't dim active windows. Currently, if user changes config of this effect, active window becomes dimmed. The reason for that is we hit that special case when deciding whether effects->activeWindow() should be m_activeWindow. This change addresses that problem by resetting m_activeWindow so we don't hit that special case. Test Plan: * Opened KCM of this effect; * Changed strength; * (the KCM window stayed bright after I clicked "Apply" button). (everything else works as expected) Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D14973 |
6 years ago | |
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| diminactive.cpp | 6 years ago | |
| diminactive.h | 6 years ago | |
| diminactive.kcfg | ||
| diminactive_config.cpp | 6 years ago | |
| diminactive_config.desktop | 6 years ago | |
| diminactive_config.h | 6 years ago | |
| diminactive_config.ui | 6 years ago | |
| diminactiveconfig.kcfgc | ||