You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
David Edmundson 47be4be020 [scripting] Make DBus invokable run method return result after execution
Summary:
In 403038 the user expected the DBus call to run to finish before
processing the next request. For a singleshot script that makes a lot of
sense, otherwise you have no idea when it finishes.

This also allows us to return errors.

CCBUG: 403038

Test Plan:
NUM=$(qdbus org.kde.KWin /Scripting org.kde.kwin.Scripting.loadScript /noFile.js Minimize)
qdbus org.kde.KWin /$NUM org.kde.kwin.Scripting.run
  Error: org.kde.kwin.Scripting.FileError
  Could not open /noFile.js

Running a real script behaved effectively the same as before.

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D18127
6 years ago
..
CMakeLists.txt
Messages.sh
dbuscall.cpp
dbuscall.h Overhaul doxygen comments 6 years ago
documentation-effect-global.xml
documentation-global.xml
genericscriptedconfig.cpp
genericscriptedconfig.h
genericscriptedconfig.json
kwinscript.desktop
meta.cpp
meta.h Overhaul doxygen comments 6 years ago
screenedgeitem.cpp
screenedgeitem.h Overhaul doxygen comments 6 years ago
scriptedeffect.cpp
scriptedeffect.h Overhaul doxygen comments 6 years ago
scripting.cpp [scripting] Make DBus invokable run method return result after execution 6 years ago
scripting.h [scripting] Make DBus invokable run method return result after execution 6 years ago
scripting_logging.cpp
scripting_logging.h
scripting_model.cpp
scripting_model.h Overhaul doxygen comments 6 years ago
scriptingutils.cpp
scriptingutils.h
timer.cpp
workspace_wrapper.cpp
workspace_wrapper.h Overhaul doxygen comments 6 years ago