You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused. |
2 years ago | |
|---|---|---|
| .. | ||
| CMakeLists.txt | 2 years ago | |
| cursorhotspottest.cpp | 2 years ago | |
| inputmethodstest.qml | ||
| lockscreenoverlaytest.cpp | 2 years ago | |
| lockscreenoverlaytest.desktop | 2 years ago | |
| normalhintsbasesizetest.cpp | ||
| pointerconstraintstest.cpp | 2 years ago | |
| pointerconstraintstest.h | 2 years ago | |
| pointerconstraintstest.qml | ||
| pointergesturestest.cpp | 2 years ago | |
| pointergesturestest.qml | ||
| screenedgeshowtest.cpp | ||
| unmapdestroytest.qml | ||
| x11shadowreader.cpp | ||
| xdgactivationtest-qt5.cpp | ||
| xdgactivationtest-qt6.cpp | ||