You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
7fffe99328
Due to being a compositor, kwin has to conform to some certain interfaces. It means a lot of virtual functions and function tables to integrate with C APIs. Naturally, we not always want to use every argument in such functions. Since we get -Wunused-parameter from -Wall, we have to plumb those unused arguments in order to suppress compiler warnings at the moment. However, I don't think that extra work is worth it. We cannot change or alter prototypes in any way to fix the warning the desired way. Q_UNUSED and similar macros are not good indicators of whether an argument is used too, we tend to overlook putting or removing those macros. I've also noticed that Q_UNUSED are not used to guide us with the removal no longer needed parameters. Therefore, I think it's worth adding -Wno-unused-parameter compiler option to stop the compiler producing warnings about unused parameters. It changes nothing except that we don't need to put Q_UNUSED anymore, which can be really cumbersome sometimes. Note that it doesn't affect unused variables, you'll still get a -Wunused-variable compiler warning if a variable is unused. |
2 years ago | |
|---|---|---|
| .. | ||
| data | ||
| effects | 2 years ago | |
| fakes | 2 years ago | |
| helper | 2 years ago | |
| protocols | ||
| scripting | 2 years ago | |
| CMakeLists.txt | 2 years ago | |
| activation_test.cpp | 2 years ago | |
| activities_test.cpp | 2 years ago | |
| buffer_size_change_test.cpp | 2 years ago | |
| dbus_interface_test.cpp | 2 years ago | |
| debug_console_test.cpp | 2 years ago | |
| decoration_input_test.cpp | 2 years ago | |
| desktop_window_x11_test.cpp | 2 years ago | |
| dont_crash_aurorae_destroy_deco.cpp | 2 years ago | |
| dont_crash_cancel_animation.cpp | 2 years ago | |
| dont_crash_empty_deco.cpp | 2 years ago | |
| dont_crash_glxgears.cpp | 2 years ago | |
| dont_crash_no_border.cpp | 2 years ago | |
| dont_crash_reinitialize_compositor.cpp | 2 years ago | |
| dont_crash_useractions_menu.cpp | 2 years ago | |
| generic_scene_opengl_test.cpp | 2 years ago | |
| generic_scene_opengl_test.h | ||
| globalshortcuts_test.cpp | 2 years ago | |
| idle_inhibition_test.cpp | 2 years ago | |
| input_stacking_order.cpp | 2 years ago | |
| inputmethod_test.cpp | 2 years ago | |
| internal_window.cpp | 2 years ago | |
| keyboard_layout_test.cpp | 2 years ago | |
| keymap_creation_failure_test.cpp | 2 years ago | |
| kwin_wayland_test.cpp | 2 years ago | |
| kwin_wayland_test.h | 2 years ago | |
| kwinbindings_test.cpp | 2 years ago | |
| layershellv1window_test.cpp | 2 years ago | |
| lockscreen.cpp | 2 years ago | |
| maximize_test.cpp | 2 years ago | |
| modifier_only_shortcut_test.cpp | 2 years ago | |
| move_resize_window_test.cpp | 2 years ago | |
| nightcolor_test.cpp | 2 years ago | |
| no_global_shortcuts_test.cpp | 2 years ago | |
| outputchanges_test.cpp | 2 years ago | |
| placement_test.cpp | 2 years ago | |
| plasma_surface_test.cpp | 2 years ago | |
| plasmawindow_test.cpp | 2 years ago | |
| platformcursor.cpp | 2 years ago | |
| pointer_constraints_test.cpp | 2 years ago | |
| pointer_input.cpp | 2 years ago | |
| quick_tiling_test.cpp | 2 years ago | |
| scene_opengl_es_test.cpp | ||
| scene_opengl_test.cpp | ||
| screen_changes_test.cpp | 2 years ago | |
| screenedge_client_show_test.cpp | 2 years ago | |
| screenedges_test.cpp | 2 years ago | |
| screens_test.cpp | 2 years ago | |
| shade_test.cpp | 2 years ago | |
| showing_desktop_test.cpp | 2 years ago | |
| stacking_order_test.cpp | 2 years ago | |
| struts_test.cpp | 2 years ago | |
| tabbox_test.cpp | 2 years ago | |
| test_helpers.cpp | 2 years ago | |
| test_virtualkeyboard_dbus.cpp | 2 years ago | |
| touch_input_test.cpp | 2 years ago | |
| transient_placement.cpp | 2 years ago | |
| virtual_desktop_test.cpp | 2 years ago | |
| window_rules_test.cpp | 2 years ago | |
| window_selection_test.cpp | 2 years ago | |
| x11_window_test.cpp | 2 years ago | |
| xdgshellwindow_rules_test.cpp | 2 years ago | |
| xdgshellwindow_test.cpp | 2 years ago | |
| xwayland_input_test.cpp | 2 years ago | |
| xwayland_selections_test.cpp | 2 years ago | |
| xwaylandserver_crash_test.cpp | 2 years ago | |
| xwaylandserver_restart_test.cpp | 2 years ago | |