You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
David Edmundson e3044e619e Correctly align natural layout in present windows
Summary:
Present windows works as follows:

- It moves all windows about until nothing is overlapping with any
other window.
- This doesn't resize anything so ultimately we end up with a new
co-ordinate space that's bigger than the screen depending on the amount
of overlap.

 - We then render this whole view transformed to the screen

The rectangle "bounds" is in overviewpixels, with "scale" being the
ratio to convert to screen pixels.

When adjusting the new bounds there's an attempt to centre align things.
As bounds is in "overviewpixels" we multiply references to the previous
bounds by scale, and divide everything through at the end. bounds.x/y
were missed.

This is mostly unoticable except on massive super-ultra-wide monitors
which will otherwise have a tendency to shift to the left.

Test Plan:
Kai created a whole new test framework for this code that copy pasted
this algorithm then showed mock windows as rectangles

Reviewers: #kwin, apol, broulik, zzag

Reviewed By: #kwin, apol, broulik, zzag

Subscribers: zzag, apol, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D29705
4 years ago
..
CMakeLists.txt Reduce the amount of objects that are compiled several times 5 years ago
main.qml [effects/presentwindows] Port present windows to EffectQuickView 5 years ago
presentwindows.cpp Correctly align natural layout in present windows 4 years ago
presentwindows.h [effects/presentwindows] Use windowFrameGeometryChanged 5 years ago
presentwindows.kcfg
presentwindows_config.cpp Port away from overloaded KCModule signal 5 years ago
presentwindows_config.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 5 years ago
presentwindows_config.h
presentwindows_config.ui
presentwindows_proxy.cpp
presentwindows_proxy.h
presentwindowsconfig.kcfgc