You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 
Martin Gräßlin 537cc148df Get the logind session to take over through env variable instead of own PID
Summary:
So far KWin resolved the logind session to take over by  using its own
PID with the method GetSessionByPID. This doesn't work if KWin itself
is not part of the session or if KWin is supposed to take over a
different session.

The session to take over is now derived from XDG_SESSION_ID. If it is
not set the variant through getSessionByPID is used.

This allows to e.g. run kwin on vt1, but have the graphical output
on vt2. Thus it's possible to see the debug output. Also it should allow
to run kwin_wayland through an ssh session, so that gdb can be used.

If we take over another session on a different vt, we need to make sure
that it's the current virtual terminal. Otherwise assumptions in the
startup code would break. So let's ensure the session we integrate with
is active.

Reviewers: #plasma

Subscribers: plasma-devel

Projects: #plasma

Differential Revision: https://phabricator.kde.org/D1445
9 years ago
autotests Create screen edge through the Platform 9 years ago
cmake/modules Check for Xwayland as RUNTIME dependency 9 years ago
data [plugins/platforms] Dedicated logging category for X11 standalone platform 9 years ago
decorations Add an explicit dependency to Breeze to find decoration plugin 9 years ago
doc Update kwindecoration docbook to 5.6 9 years ago
effects SVN_SILENT made messages (.desktop file) - always resolve ours 9 years ago
kcmkwin SVN_SILENT made messages (.desktop file) - always resolve ours 9 years ago
killer
libinput Fix build of stable branch on build.kde.org 9 years ago
libkwineffects use a global static for animation ids 9 years ago
plugins [platforms/hwcomposer] Remove integration with VirtualTerminal 9 years ago
qml
scripting try more aggressively to retarget 9 years ago
scripts SVN_SILENT made messages (.desktop file) - always resolve ours 9 years ago
shaders [libkwinglutils] Cleanup Shader API: removal of ShaderType 9 years ago
tabbox Pass pointer and wheel events to TabBox from special event filter 9 years ago
tests KWin::Application holdes a KSharedConfigPtr with the config 9 years ago
.arcconfig Adding .arcconfig 9 years ago
.reviewboardrc
16-apps-kwin.png
32-apps-kwin.png
48-apps-kwin.png
CMakeLists.txt Move clients/ to plugins/kdecorations/ 9 years ago
COMPLIANCE
CONFIGURING
COPYING
COPYING.DOC
ExtraDesktop.sh
HACKING
KWinDBusInterfaceConfig.cmake.in
Mainpage.dox
Messages.sh
README
abstract_client.cpp Hook up virtual_desktop_changeable state. 9 years ago
abstract_client.h Fix start move through drag distance on window decoration 9 years ago
abstract_egl_backend.cpp Properly update EGL Texture for sub-surface buffers 9 years ago
abstract_egl_backend.h
activation.cpp restrict cross-vd activation to in-client distrib 9 years ago
activities.cpp Remove saving and loading (and client matching by) WM_COMMAND. 9 years ago
activities.h
atoms.cpp
atoms.h Create screen edge through the Platform 9 years ago
client.cpp Fix repaints area on Wayland damage 9 years ago
client.h Strut sanity checking: ignore struts which would exclude a complete screen 9 years ago
client_machine.cpp
client_machine.h
composite.cpp Don't check for waylandServer() when accessing the platform in Compositor 9 years ago
composite.h
compositingprefs.cpp Use kwinApp()->config() instead of KSharedConfig::openConfig() 9 years ago
compositingprefs.h
config-kwin.h.cmake Add an explicit dependency to Breeze to find decoration plugin 9 years ago
cursor.cpp Add Cursor::cursorAlternativeNames 9 years ago
cursor.h Add Cursor::cursorAlternativeNames 9 years ago
dbusinterface.cpp Add a debugging console to KWin 9 years ago
dbusinterface.h Add a debugging console to KWin 9 years ago
debug_console.cpp Use a QTabWidget for the different modes in DebugConsole 9 years ago
debug_console.h Input events mode in debug console 9 years ago
debug_console.ui Use a QTabWidget for the different modes in DebugConsole 9 years ago
deleted.cpp Port to CMake AUTOMOC 9 years ago
deleted.h [kwineffects] Expose fullScreen property in EffectWindow 9 years ago
effectloader.cpp
effectloader.h
effects.cpp Rename abstract_backend.(h|cpp) to platform.(h|cpp) 9 years ago
effects.h Add bool checkInputWindowEvent(QWheelEvent *e) to EffectsHandlerImpl 9 years ago
events.cpp Warp the cursor pos to the specificed global position in a NET::Move request 9 years ago
focuschain.cpp
focuschain.h
geometry.cpp Strut sanity checking: ignore struts which would exclude a complete screen 9 years ago
geometrytip.cpp Port to CMake AUTOMOC 9 years ago
geometrytip.h
globalshortcuts.cpp
globalshortcuts.h
group.cpp
group.h
input.cpp Integrate libinput only through Logind instead of relying on VirtualTerminal 9 years ago
input.h Implement internal keyboard repeat 9 years ago
keyboard_input.cpp Fix build of stable branch on build.kde.org (Try 2) 9 years ago
keyboard_input.h Connect to dbus signal reloadConfig from org.kde.keyboar /Layouts 9 years ago
killwindow.cpp
killwindow.h
kwin.kcfg
kwin.notifyrc SVN_SILENT made messages (.desktop file) - always resolve ours 9 years ago
kwinbindings.cpp
lanczosfilter.cpp Use shader traits API for lanczos filter's shader 9 years ago
lanczosfilter.h Use shader traits API for lanczos filter's shader 9 years ago
layers.cpp
logind.cpp Get the logind session to take over through env variable instead of own PID 9 years ago
logind.h Switch virtual teminal through logind seat 9 years ago
main.cpp Rename abstract_backend.(h|cpp) to platform.(h|cpp) 9 years ago
main.h Rename AbstractBackend to Platform 9 years ago
main_wayland.cpp Rename abstract_backend.(h|cpp) to platform.(h|cpp) 9 years ago
main_wayland.h Remove crash handling in kwin_wayland 9 years ago
main_x11.cpp Load and init the KWinX11Platform plugin in main_x11 9 years ago
main_x11.h Move global event filter from Application to ApplicationX11 9 years ago
manage.cpp
netinfo.cpp
netinfo.h
options.cpp Use kwinApp()->config() instead of KSharedConfig::openConfig() 9 years ago
options.h Implement modifier+click in InputRedirection for Wayland 9 years ago
org.freedesktop.ScreenSaver.xml
org.kde.KWin.xml Add a debugging console to KWin 9 years ago
org.kde.kwin.Compositing.xml
org.kde.kwin.Effects.xml
outline.cpp Make QmlPath in Outline configurable 9 years ago
outline.h
overlaywindow.cpp
overlaywindow.h Move glxbackend to x11 standalone plugin 9 years ago
placement.cpp Fix typo 9 years ago
placement.h
platform.cpp Create screen edge through the Platform 9 years ago
platform.h Create screen edge through the Platform 9 years ago
pointer_input.cpp Rename abstract_backend.(h|cpp) to platform.(h|cpp) 9 years ago
pointer_input.h Add support for Drag'n'Drop on Wayland 9 years ago
resources.qrc [libkwinglutils] Cleanup Shader API: removal of ShaderType 9 years ago
rules.cpp
rules.h
sc-apps-kwin.svgz
scene.cpp Use new surface() method in WindowPixmap::updateBuffer 9 years ago
scene.h Add a SurfaceInterface *WindowPixmap::surface() const 9 years ago
scene_opengl.cpp Move glxbackend to x11 standalone plugin 9 years ago
scene_opengl.h Move glxbackend to x11 standalone plugin 9 years ago
scene_qpainter.cpp Don't check window system when creating SceneQPainter 9 years ago
scene_qpainter.h Create sub OpenGLWindowPixmap for sub-surfaces 9 years ago
scene_xrender.cpp Checking whether the m_textTexture is not null before dereferencing it 9 years ago
scene_xrender.h
screenedge.cpp Create screen edge through the Platform 9 years ago
screenedge.h Create screen edge through the Platform 9 years ago
screens.cpp Move XRandrScreens to the x11/standalone plugin 9 years ago
screens.h Rename AbstractBackend to Platform 9 years ago
settings.kcfgc
shadow.cpp Checking whether m_topLevel is not null before getting its property 9 years ago
shadow.h
shell_client.cpp ShellClient's m_shellSurface might be null 9 years ago
shell_client.h Move ShellClient initialization code into a dedicated init method 9 years ago
shortcutdialog.ui
sm.cpp Port to CMake AUTOMOC 9 years ago
sm.h Remove saving and loading (and client matching by) WM_COMMAND. 9 years ago
tabgroup.cpp
tabgroup.h
thumbnailitem.cpp
thumbnailitem.h
toplevel.cpp Consider change in sub-surface tree as a full damage 9 years ago
toplevel.h Remove saving and loading (and client matching by) WM_COMMAND. 9 years ago
touch_input.cpp Reset TouchInputRedirection::m_inited when Workspace or WaylandServer get destroyed 9 years ago
touch_input.h Split out touch related functionality from InputRedirection 9 years ago
udev.cpp
udev.h
unmanaged.cpp Port to CMake AUTOMOC 9 years ago
unmanaged.h
useractions.cpp Merge Options::MouseLower for Client and AbstractClient 9 years ago
useractions.h
utils.cpp Port to CMake AUTOMOC 9 years ago
utils.h
virtual_terminal.cpp Fix build with future glibc (major/minor macros) 9 years ago
virtual_terminal.h
virtualdesktops.cpp
virtualdesktops.h
wayland_cursor_theme.cpp Fix fallback resolution in WaylandCursorTheme 9 years ago
wayland_cursor_theme.h Clear cursor cache on theme changes 9 years ago
wayland_server.cpp Rename abstract_backend.(h|cpp) to platform.(h|cpp) 9 years ago
wayland_server.h Drop backend() -> AbstractBackend* from WaylandServer 9 years ago
workspace.cpp Add a Toplevel *Workspace::findInternal(QWindow *w) const 9 years ago
workspace.h Add a Toplevel *Workspace::findInternal(QWindow *w) const 9 years ago
x11eventfilter.cpp
x11eventfilter.h Move XRandrScreens to the x11/standalone plugin 9 years ago
xcbutils.cpp
xcbutils.h

README

- A collection of various documents and links related to KWin is at http://techbase.kde.org/Projects/KWin .


- The mailing list for KWin is kwin@kde.org (https://mail.kde.org/mailman/listinfo/kwin).

- If you want to develop KWin, see file HACKING.

- If you want to check KWin's compliance with specifications, see file COMPLIANCE.

- File CONFIGURATION includes some details on configuring KWin.

- Below is some info for application developers about application interaction
  with the window manager, but it'd need some cleanup.








 This README is meant as an explanation of various window manager related
mechanisms that application developers need to be aware of. As some of these
concepts may be difficult to understand for people not having the required
background knowledge (since sometimes it's difficult even for people who
do have the knowledge), the mechanisms are first briefly explained, and
then an example of fixing the various problems is given.

 For comments, questions, suggestions and whatever use the kwin@kde.org
mailing list.


Table of contents:
==================

- Window relations
    - how to make the window manager know which windows belong together
- Focus stealing prevention
    - how to solve cases where focus stealing prevention doesn't work
      properly automatically



Window relations:
=================

(For now, this explanation of window relations is mainly meant for
focus stealing prevention. To be extended later.)

 All windows created by an application should be organized in a tree
with the root being the application's main window. Note that this is about
toplevel windows, not widgets inside the windows. For example, if you
have KWrite running, with a torn-off toolbar (i.e. a standalone toolbar),
a file save dialog open, and the file save dialog showing a dialog
for creating a directory, the window hiearchy should look like this:


             KWrite mainwindow
              /             \
             /               \
      file save dialog      torn-off toolbar
            \
             \
          create directory dialog

 Each subwindow (i.e. all except for the KWrite mainwindow) points to its
main window (which in turn may have another main window, as in the case
of the file save dialog). When the window manager knows these relations,
it can better arrange the windows (keeping subwindows above their
main windows, preventing activation of a main window of a modal dialog,
and similar). Failing to provide this information to the window manager
may have various results, for example having dialogs positioned below
the main window,

The window property used by subwindows to point to their mainwindows is
called WM_TRANSIENT_FOR. It can be seen by running
'xprop | grep WM_TRANSIENT_FOR' and clicking on a window. If the property
is not present, the window does not (claim to) have any mainwindow.
If the property is present, it's value is the window id of its main window;
window id of any window can be found out by running 'xwininfo'. A window
having WM_TRANSIENT_FOR poiting to another window is said to be transient
for that window.

 In some cases, the WM_TRANSIENT_FOR property may not point to any other
existing window, having value of 0, or pointing to the screen number
('xwininfo -root'). These special values mean that the window is transient
for all other windows in its window group. This should be used only
in rare cases, everytime a specific main window is known, WM_TRANSIENT_FOR
should be pointing to it instead of using one of these special values.
(The explanation why is beyond the scope of this document - just accept it
as a fact.)

 With Qt, the WM_TRANSIENT_FOR property is set by Qt automatically, based
on the toplevel widget's parent. If the toplevel widget is of a normal
type (i.e. not a dialog, toolbar, etc.), Qt doesn't set WM_TRANSIENT_FOR
on it. For special widgets, such as dialogs, WM_TRANSIENT_FOR is set
to point to the widget's parent, if it has a specific parent, otherwise
WM_TRANSIENT_FOR points to the root window.

 As already said above, WM_TRANSIENT_FOR poiting to the root window should
be usually avoided, so everytime the widget's main widget is known, the widget
should get it passed as a parent in its constructor.
(TODO KDialog etc. classes should not have a default argument for the parent
argument, and comments like 'just pass 0 as the parent' should go.)



Focus stealing prevention:
==========================

 Since KDE3.2 KWin has a feature called focus stealing prevention. As the name
suggests, it prevents unexpected changes of focus. With older versions of KWin,
if any application opened a new dialog, it became active, and
if the application's main window was on another virtual desktop, also
the virtual desktop was changed. This was annoying, and also sometimes led
to dialogs mistakenly being closed because they received keyboard input that
was meant for the previously active window.

 The basic principle of focus stealing prevention is that the window with most
recent user activity wins. Any window of an application will become active
when being shown only if this application was the most recently used one.
KWin itself, and some of the related kdecore classes should take care
of the common cases, so usually there's no need for any special handling
in applications. Qt/KDE applications, that is. Applications using other
toolkits should in most cases work fine too. If they don't support
the window property _NET_WM_USER_TIME, the window manager may fail to detect
the user timestamp properly, resulting either in other windows becoming active
while the user works with this application, or this application may sometimes
steal focus (this second case should be very rare though).

 There are also cases where KDE applications needs special handling. The two
most common cases are when windows relations are not setup properly to make
KWin realize that they belong to the same application, and when the user
activity is not represented by manipulating with the application windows
themselves.

 Also note that focus stealing prevention implemented in the window manager
can only help with focus stealing between different applications.
If an application itself suddenly pops up a dialog, KWin cannot do anything about
it, and its the application's job to handle this case.


Window relations:
-----------------

 The common case here is when a dialog is shown for an application, but this
dialog is not provided by the application itself, but by some other process.
For example, dialogs with warnings about accepted cookies are provided
by KCookieJar, instead of being shown by Konqueror. In the normal case,
from KWin's point of view the cookie dialog would be an attempt of another
application to show a dialog, and KWin wouldn't allow activation of this
window.

 The solution is to tell the window manager about the relation between
the Konqueror main window and the cookie dialog, by making the dialog
point to the mainwindow. Note that this is not special to focus stealing
prevention, subwindows such as dialogs, toolbars and similar should always
point to their mainwindow. See the section on window relations for full
description.

 The WM_TRANSIENT_FOR property that's set on dialogs to point to their
mainwindow should in the cookie dialog case point to the Konqueror window
for which it has been shown. This is solved in kcookiejar by including
the window id in the DCOP call. When the cookie dialog is shown, its
WM_TRANSIENT_FOR property is manually set using the XSetTransientForHint()
call (see kdelibs/kioslave/http/kcookiejar/kcookiewin.cpp). The arguments
to XSetTransientForHint() call are the X display (i.e. QX11Info::display()),
the window id on which the WM_TRANSIENT_FOR property is to be set
(i.e. use QWidget::winId()), and the window id of the mainwindow.


  Simple short HOWTO:
  
 To put it simply: Let's say you have a daemon application that has
DCOP call "showDialog( QString text )", and when this is called, it shows
a dialog with the given text. This won't work properly with focus stealing
prevention. The DCOP call should be changed to
"showDialog( QString text, long id )". The caller should pass something like
myMainWindow->winId() as the second argument. In the daemon, before
the dialog is shown, a call to XSetTransientHint() should be added:

 XSetTransientForHint( QX11Info::display(), dialog->winId(), id_of_mainwindow );
 
 That's it.

Non-standard user activity:
---------------------------

 The most common case in KDE will be DCOP calls. For example, KDesktop's DCOP
call "KDesktopIface popupExecuteCommand". Executing this DCOP call e.g.
from Konsole as 'dcop kdesktop KDesktopIface popupExecuteCommand" will lead
to showing the minicli, but the last user activity timestamp gained from events
sent by X server will be older than user activity timestamp of Konsole, and
would normally result in minicli not being active. Therefore, before showing
the minicli, kdesktop needs to call KApplication::updateUserTimestamp().

 However, this shouldn't be done with all DCOP calls. If a DCOP call is not
a result of direct user action, calling KApplication::updateUserTimestamp()
would lead to focus stealing. For example, let's assume for a moment
that KMail would use this DCOP call in case it detects the modem is not
connected, allowing to you to start KPPP or whatever tool you use. If KMail
would be configured to check mail every 10 minutes, this would lead to minicli
possibly suddenly showing up at every check. Basically, doing the above change
to kdesktop's minicli means that the popupExecuteCommand() DCOP call is only
for user scripting. (TODO write about focus transferring?)

 Simply said, KApplication::updateUserTimestamp() should be called only
as a result of user action. Unfortunately, I'm not aware of any universal
way how to handle this, so every case will have to be considered separately.