effects/screentransform: Don't read kscreen effect's config

It's fine to have the animation duration hardcoded to 250ms. The main
issue with reading kscreen effect's config is that it adds inter-effect
dependencies, which is simply not worth the trouble.
master
Vlad Zahorodnii 3 years ago
parent bdc7ee649b
commit f51ad0897f

@ -8,7 +8,6 @@
*/
// own
#include "screentransform.h"
#include "../kscreen/kscreenconfig.h"
#include "kwinglutils.h"
#include <QDebug>
@ -17,9 +16,6 @@ namespace KWin
ScreenTransformEffect::ScreenTransformEffect()
: Effect()
{
initConfig<KscreenConfig>();
reconfigure(ReconfigureAll);
const QList<EffectScreen *> screens = effects->screens();
for (auto screen : screens) {
addScreen(screen);
@ -53,7 +49,7 @@ void ScreenTransformEffect::addScreen(EffectScreen *screen)
m_states.remove(screen);
return;
}
state.m_timeLine.setDuration(std::chrono::milliseconds(animationTime<KscreenConfig>(250)));
state.m_timeLine.setDuration(std::chrono::milliseconds(long(animationTime(250))));
state.m_timeLine.setEasingCurve(QEasingCurve::OutCirc);
state.m_lastPresentTime = std::chrono::milliseconds::zero();
state.m_angle = transformAngle(screen->transform(), state.m_oldTransform);
@ -90,12 +86,6 @@ void ScreenTransformEffect::removeScreen(EffectScreen *screen)
effects->doneOpenGLContextCurrent();
}
void ScreenTransformEffect::reconfigure(ReconfigureFlags flags)
{
Q_UNUSED(flags)
KscreenConfig::self()->read();
}
void ScreenTransformEffect::prePaintScreen(ScreenPrePaintData &data, std::chrono::milliseconds presentTime)
{
if (isScreenTransforming(data.screen)) {

@ -29,7 +29,6 @@ public:
void prePaintWindow(EffectWindow *w, WindowPrePaintData &data, std::chrono::milliseconds presentTime) override;
void paintWindow(EffectWindow *w, int mask, QRegion region, WindowPaintData &data) override;
void reconfigure(ReconfigureFlags flags) override;
bool isActive() const override;
int requestedEffectChainPosition() const override

Loading…
Cancel
Save