From dd5ec684b7b9bd56af55e7c627755fdc6af4667c Mon Sep 17 00:00:00 2001 From: Kristen McWilliam Date: Mon, 16 Oct 2023 10:32:23 -0400 Subject: [PATCH] `include-shadow` defaults to `true` so this isn't a breaking change --- src/plugins/screenshot/org.kde.KWin.ScreenShot2.xml | 6 +++--- src/plugins/screenshot/screenshotdbusinterface2.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/screenshot/org.kde.KWin.ScreenShot2.xml b/src/plugins/screenshot/org.kde.KWin.ScreenShot2.xml index da0d163b99..bf515f286d 100644 --- a/src/plugins/screenshot/org.kde.KWin.ScreenShot2.xml +++ b/src/plugins/screenshot/org.kde.KWin.ScreenShot2.xml @@ -39,7 +39,7 @@ * "include-decoration" (b): Whether the decoration should be included. Defaults to false * "include-shadow" (b): Whether the shadow should be included. - Defaults to false + Defaults to true * "native-resolution" (b): Whether the screenshot should be in native size. Defaults to false @@ -89,7 +89,7 @@ * "include-decoration" (b): Whether the decoration should be included. Defaults to false * "include-shadow" (b): Whether the shadow should be included. - Defaults to false + Defaults to true * "native-resolution" (b): Whether the screenshot should be in native size. Defaults to false @@ -273,7 +273,7 @@ * "include-decoration" (b): Whether the decoration should be included. Defaults to false * "include-shadow" (b): Whether the shadow should be included. - Defaults to false + Defaults to true * "native-resolution" (b): Whether the screenshot should be in native size. Defaults to false diff --git a/src/plugins/screenshot/screenshotdbusinterface2.cpp b/src/plugins/screenshot/screenshotdbusinterface2.cpp index ad3eefc92e..16f102cdcc 100644 --- a/src/plugins/screenshot/screenshotdbusinterface2.cpp +++ b/src/plugins/screenshot/screenshotdbusinterface2.cpp @@ -107,7 +107,7 @@ static ScreenShotFlags screenShotFlagsFromOptions(const QVariantMap &options) flags |= ScreenShotIncludeDecoration; } - const QVariant includeShadow = options.value(QStringLiteral("include-shadow")); + const QVariant includeShadow = options.value(QStringLiteral("include-shadow"), true); if (includeShadow.toBool()) { flags |= ScreenShotIncludeShadow; }