From d83da1cdacc4ffe2fa09d3d6a8bdfed12ff7950b Mon Sep 17 00:00:00 2001 From: Xaver Hugl Date: Sun, 3 Oct 2021 16:32:10 +0200 Subject: [PATCH] platforms/drm: remove redundant check for placeholder output It's not necessary, the placeholder output already gets created in DrmBackend::removeOutput if necessary. More improtantly it's missing the check for shutdown, which may cause issues if the computer is turned off while no outputs are connected. --- src/plugins/platforms/drm/drm_backend.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/plugins/platforms/drm/drm_backend.cpp b/src/plugins/platforms/drm/drm_backend.cpp index 3c6e691f2d..372fba22c1 100644 --- a/src/plugins/platforms/drm/drm_backend.cpp +++ b/src/plugins/platforms/drm/drm_backend.cpp @@ -355,13 +355,6 @@ void DrmBackend::updateOutputs() } } - if (m_outputs.isEmpty()) { - qCDebug(KWIN_DRM) << "adding placeholder output"; - m_placeHolderOutput = primaryGpu()->createVirtualOutput(); - // placeholder doesn't actually need to render anything - m_placeHolderOutput->renderLoop()->inhibit(); - } - std::sort(m_outputs.begin(), m_outputs.end(), [] (DrmAbstractOutput *a, DrmAbstractOutput *b) { auto da = qobject_cast(a); auto db = qobject_cast(b);