From 40eb0e4f0e1d62ac3d3af335236bf8dd67db207d Mon Sep 17 00:00:00 2001 From: Xaver Hugl Date: Sat, 24 Apr 2021 19:46:34 +0200 Subject: [PATCH] platforms/drm: only print error for direct scanout when useful Most wayland-native apps provide buffers that aren't suitable for direct scanout; the message usually only spams the log full without proper reason or useful information --- src/plugins/platforms/drm/egl_gbm_backend.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/platforms/drm/egl_gbm_backend.cpp b/src/plugins/platforms/drm/egl_gbm_backend.cpp index 99896911b8..eac8c69bad 100644 --- a/src/plugins/platforms/drm/egl_gbm_backend.cpp +++ b/src/plugins/platforms/drm/egl_gbm_backend.cpp @@ -726,7 +726,9 @@ bool EglGbmBackend::scanout(int screenId, SurfaceItem *surfaceItem) importedBuffer = gbm_bo_import(m_gpu->gbmDevice(), GBM_BO_IMPORT_FD, &data, GBM_BO_USE_SCANOUT); } if (!importedBuffer) { - qCDebug(KWIN_DRM) << "importing the dmabuf for direct scanout failed:" << strerror(errno); + if (errno != EINVAL) { + qCWarning(KWIN_DRM) << "Importing buffer for direct scanout failed!" << strerror(errno); + } return false; } // damage tracking for screen casting