From 066492ef1db5909d5aa90416d4e97743921a2957 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Wed, 18 Oct 2023 13:09:33 +0300 Subject: [PATCH] libkwineffects: Make dirty view tracking more robust in SceneEffect It's possible that a view can request a repaint again in update(). If that happens, we don't want to overwrite the dirty state after update(). --- src/libkwineffects/kwinquickeffect.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libkwineffects/kwinquickeffect.cpp b/src/libkwineffects/kwinquickeffect.cpp index 9769d6beef..490ca75e39 100644 --- a/src/libkwineffects/kwinquickeffect.cpp +++ b/src/libkwineffects/kwinquickeffect.cpp @@ -367,14 +367,14 @@ void QuickSceneEffect::prePaintScreen(ScreenPrePaintData &data, std::chrono::mil if (effects->waylandDisplay()) { const auto it = d->views.find(data.screen); if (it != d->views.end() && it->second->isDirty()) { - it->second->update(); it->second->resetDirty(); + it->second->update(); } } else { for (const auto &[screen, screenView] : d->views) { if (screenView->isDirty()) { - screenView->update(); screenView->resetDirty(); + screenView->update(); } } }